Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 13, 2023

Resolved / Related Issues

  • Fix potential crashes that could occur if the root isn't set

@yaira2 yaira2 requested a review from d2dyno1 November 13, 2023 23:10
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 13, 2023
Revert "Fix: Always set content dialog root"

This reverts commit 119068c.

Update DecompressHelper.cs

Update CompressIntoArchiveAction.cs

Update UpdateService.cs

Root
@yaira2 yaira2 force-pushed the ya/SetContentDialogRoot branch from 6bb8c9b to 5081fbd Compare November 13, 2023 23:21
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 15, 2023
@yaira2 yaira2 merged commit 6800b1c into main Nov 15, 2023
@yaira2 yaira2 deleted the ya/SetContentDialogRoot branch November 15, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants