Skip to content

fix(auth): export MISSING_PASSWORD in AuthErrorCodes #9297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2025
Merged

fix(auth): export MISSING_PASSWORD in AuthErrorCodes #9297

merged 6 commits into from
Oct 10, 2025
+9 −0

Conversation

@Navya-arugonda
Copy link
Contributor

@Navya-arugonda Navya-arugonda commented Oct 6, 2025

Summary
Export MISSING_PASSWORD: 'auth/missing-password' via AuthErrorCodes in @firebase/auth.

Why
The SDK can throw auth/missing-password, but it wasn’t exposed via AuthErrorCodes, forcing developers to hardcode the string.

Tests
Adds a Node unit test asserting:
AuthErrorCodes.MISSING_PASSWORD === 'auth/missing-password'.

Fixes
Fixes #9270

CLA
I have signed the Google Contributor License Agreement.

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 174bd83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
firebase Patch
@firebase/auth-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Navya-arugonda Navya-arugonda requested review from a team as code owners October 6, 2025 17:11
dlarocque
dlarocque requested changes Oct 6, 2025
View reviewed changes
@dlarocque
Copy link
Contributor

dlarocque commented Oct 6, 2025 •
edited
Loading

When we make additions to public APIs, we have to update our reference documentation here on this website: https://firebase.google.com/docs/reference. The documentation hosted on that website is generated from the code in our SDK, and stored in the docs-devsite/ directory.

Since you made a public API addition, you need to generate the documentation for this new API. You can do this by running the yarn docgen:all script and committing the changes. The script will probably make changes to docs-devsite/auth.md in this case.

@Navya-arugonda
Copy link
Contributor Author

Navya-arugonda commented Oct 6, 2025

Thanks for the review!
I’ve moved MISSING_PASSWORD below MISSING_PHONE_NUMBER, reverted the tsconfig.json changes, and removed the unnecessary test file.
Please let me know if any further adjustments are needed.

dlarocque
dlarocque requested changes Oct 6, 2025
View reviewed changes
@Navya-arugonda Navya-arugonda requested a review from a team as a code owner October 6, 2025 18:21
@Navya-arugonda
Copy link
Contributor Author

Navya-arugonda commented Oct 6, 2025

Thanks for the reminder!
I’ve generated and committed the updated docs-devsite/auth.md to include the MISSING_PASSWORD export.

@dlarocque
Copy link
Contributor

dlarocque commented Oct 7, 2025

Please ignore the CI errors. They're expected to fail on forks.

One last thing though, can you run yarn build in packages/auth? It should generate a common/api-review/auth.api.md file. Can you commit that, too? Sorry I forgot about this on the first pass.

@Navya-arugonda
Copy link
Contributor Author

Navya-arugonda commented Oct 7, 2025

Added the generated auth.api.md via yarn build.

@Navya-arugonda
Copy link
Contributor Author

Navya-arugonda commented Oct 10, 2025

Hi @dlarocque 👋 just checking in — The PR looks ready from my side, but I see the workflows are awaiting maintainer approval.
Could you please take a look or trigger the workflows when you get a chance? Thank you!

@dlarocque dlarocque merged commit 2615081 into firebase:main Oct 10, 2025
42 of 44 checks passed
@dlarocque
Copy link
Contributor

dlarocque commented Oct 10, 2025

Thanks for the contribution @Navya-arugonda! ❤️

andrewbrook added a commit that referenced this pull request Oct 15, 2025
@andrewbrook @google-oss-bot
@hsubox76 @github-actions @dlarocque @Navya-arugonda
Merge origin/main (#9321)
ca7a07f 
* docs: Fix docgen script to clean out package temp folders first (#9250)

* Version Packages (#9258)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Expose setUserProperties from internal analytics instance (#9263)

* feat(ai): add support for URL context (#9254)

* docs(ai): tag code execution with "beta" tag (public preview) (#9274)

* fix(ai): Handle empty parts when streaming (#9262)

* feat(ai): Add method to send function responses in a live session (#9272)

* Update ai model name used for e2e tests (#9282)

* docs(ai): promote gemini developer api and imagen to GA (#9255)

* Version Packages (#9300) release v12.4.0

For JS SDK release v12.4.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix(auth): export MISSING_PASSWORD in AuthErrorCodes (#9297)

* update dependency

---------

Co-authored-by: Google Open Source Bot <[email protected]>
Co-authored-by: Christina Holland <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel La Rocque <[email protected]>
Co-authored-by: Navya Sree Arugonda <[email protected]>
dlarocque pushed a commit that referenced this pull request Oct 17, 2025
@Navya-arugonda @dlarocque
fix(auth): export MISSING_PASSWORD in AuthErrorCodes (#9297)
aca0367
@google-oss-bot google-oss-bot mentioned this pull request Oct 28, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Nov 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kevinthecheung kevinthecheung kevinthecheung approved these changes

@dlarocque dlarocque dlarocque approved these changes

@mansisampat mansisampat mansisampat approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"auth/missing-password" not exported via AuthErrorCodes

4 participants

@Navya-arugonda @dlarocque @kevinthecheung @mansisampat