Skip to content

Commit 9fd1102

Browse files
authored
Limit web frameworks generated functionId to 20 chars max (#6260)
1 parent 31a2588 commit 9fd1102

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
- Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)
22
- Warn if a Web Framework is outside a well known version range on deploy/emulate. (#6562)
33
- Use Web Framework's well known version range in `firebase init hosting`. (#6562)
4+
- Limit Web Framework's generated Cloud Function name to 20 characters, fixing deploys for some. (#6260)

src/frameworks/index.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,8 @@ export async function prepareFrameworks(
175175
);
176176
}
177177
const getProjectPath = (...args: string[]) => join(projectRoot, source, ...args);
178-
const functionId = `ssr${site.toLowerCase().replace(/-/g, "")}`;
178+
// Combined traffic tag (19 chars) and functionId cannot exceed 46 characters.
179+
const functionId = `ssr${site.toLowerCase().replace(/-/g, "").substring(0, 20)}`;
179180
const usesFirebaseAdminSdk = !!findDependency("firebase-admin", { cwd: getProjectPath() });
180181
const usesFirebaseJsSdk = !!findDependency("@firebase/app", { cwd: getProjectPath() });
181182
if (usesFirebaseAdminSdk) {

0 commit comments

Comments
 (0)