Skip to content

Conversation

@blidd-google
Copy link
Contributor

Fixes #6002. Further investigation has surfaced another issue where deploying individual functions specified by the --only flag will not run any predeploy hooks, but will table this issue for another fix.

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.02%. Comparing base (17eb321) to head (eafcde2).
⚠️ Report is 1569 commits behind head on master.

Files with missing lines Patch % Lines
src/deploy/lifecycleHooks.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6011      +/-   ##
==========================================
- Coverage   55.03%   55.02%   -0.01%     
==========================================
  Files         339      339              
  Lines       23220    23222       +2     
  Branches     4746     4747       +1     
==========================================
  Hits        12779    12779              
- Misses       9311     9313       +2     
  Partials     1130     1130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blidd-google blidd-google enabled auto-merge (squash) June 20, 2023 23:16
@blidd-google blidd-google merged commit c552816 into master Jun 20, 2023
@sam-throne
Copy link

The issue with hooks not running when deploying individual functions did not exist before! That's a new regression introduced by this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloud Function lifecycle hooks don't respect codebase filters

4 participants