dependency, lint upgrades (#502)

* upgrade dev dependencies

* minor updates to chai

* bulk lint fixes

* remove two 'easy' lint rules

* remove another lint rule

* remove unused rule

* remove another lint config

* oops, keep this

Author: bkendall

eslint.config.mjs

@@ -25,12 +25,6 @@ export default [
       "jsdoc/require-returns-type": "off",
 
       "@typescript-eslint/no-require-imports": "warn", // TODO(bkendall): remove allow to error.
-      "@typescript-eslint/no-unused-expressions": "warn", // TODO(bkendall): remove allow to error.
-      "@typescript-eslint/no-unused-vars": "warn", // TODO(bkendall): remove allow to error.
-      "@typescript-eslint/prefer-includes": "warn", // TODO(bkendall): remove allow to error.
-      "@typescript-eslint/prefer-optional-chain": "warn", // TODO(bkendall): remove allow to error.
-      "@typescript-eslint/prefer-promise-reject-errors": "warn", // TODO(bkendall): remove allow to error.
-      "@typescript-eslint/prefer-nullish-coalescing": "warn", // TODO(bkendall): remove allow to error.
 
       "no-unused-vars": "off", // Turned off in favor of @typescript-eslint/no-unused-vars.
       "require-atomic-updates": "off", // This rule is so noisy and isn't useful: https://github.com/eslint/eslint/issues/11899

package-lock.json

@@ -88,13 +88,13 @@
     "eslint": "^9.35.0",
     "eslint-config-google": "^0.14.0",
     "eslint-config-prettier": "^10.1.8",
-    "eslint-plugin-jsdoc": "^55.0.0",
+    "eslint-plugin-jsdoc": "^60.6.0",
     "eslint-plugin-prettier": "^5.5.4",
     "globals": "^16.3.0",
     "mocha": "^11.7.2",
     "nyc": "^17.0.0",
     "prettier": "^3.1.1",
-    "rimraf": "^5.0.1",
+    "rimraf": "^6.0.1",
     "sinon": "^17.0.1",
     "sinon-chai": "^3.7.0",
     "source-map-support": "^0.5.21",

package.json

@@ -59,7 +59,7 @@ Activator.prototype.build = function () {
 
   return function (req, res, next) {
     promiseback(self.awaitConfig, 2)(req, res).then((config) => {
-      req.superstatic = config || {};
+      req.superstatic = config ?? {};
 
       const stack = self.stack.slice(0).reverse();
       const _run = function () {

src/activator.js

@@ -21,10 +21,10 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-const updateNotifier = require("update-notifier-cjs"); // eslint-disable-line @typescript-eslint/no-var-requires
+const updateNotifier = require("update-notifier-cjs");
 
 import cli from "../cli";
-const pkg = require("../../package.json"); // eslint-disable-line @typescript-eslint/no-var-requires
+const pkg = require("../../package.json");
 
 const updateCheckInterval = 1000 * 60 * 60 * 24 * 7; // 1 week
 

src/bin/server.ts

@@ -23,7 +23,7 @@ import { Command } from "commander";
 import * as fs from "node:fs";
 import * as path from "node:path";
 
-const pkg = require("../../package.json"); // eslint-disable-line @typescript-eslint/no-var-requires
+const pkg = require("../../package.json");
 import server = require("../server");
 
 const PORT = "3474";
@@ -34,7 +34,7 @@ const ENV_FILENAME = ".env.json";
 let env: Record<string, string> | undefined = undefined;
 try {
   env = JSON.parse(fs.readFileSync(path.resolve(ENV_FILENAME), "utf8"));
-} catch (e) {
+} catch {
   // do nothing
 }
 
@@ -65,7 +65,6 @@ cli
       });
       app.listen(() => resolve());
       console.log(
-        // eslint-disable-next-line @typescript-eslint/restrict-template-expressions
         `Superstatic started.\nVisit http://${options.hostname}:${options.port} to view your app.`,
       );
     });

src/cli/index.ts

@@ -32,15 +32,15 @@ module.exports = function (filename) {
     return filename;
   }
 
-  filename = filename || CONFIG_FILE;
+  filename = filename ?? CONFIG_FILE;
 
   let configObject = {};
   let config = {};
 
   // From custom config data passed in
   try {
     configObject = JSON.parse(filename);
-  } catch (e) {
+  } catch {
     if (_.isPlainObject(filename)) {
       configObject = filename;
       filename = CONFIG_FILE;
@@ -63,8 +63,8 @@ module.exports = function (filename) {
   if (_.isString(filename) && _.endsWith(filename, "json")) {
     try {
       config = JSON.parse(fs.readFileSync(path.resolve(filename)));
-      config = config.hosting ? config.hosting : config;
-    } catch (e) {
+      config = config.hosting ?? config;
+    } catch {
       // do nothing
     }
   }

src/loaders/config-file.js

@@ -42,7 +42,7 @@ interface SuperstaticResponse {
  * Returns middleware for `/__/env.json|js`.
  * @param spec superstatic options.
  * @param spec.env environment variables.
- * @return middleware.
+ * @returns middleware.
  */
 export function env(spec: { env: Record<string, string> }) {
   return (

src/middleware/env.ts

@@ -27,7 +27,7 @@ const url = require("url");
 /**
  * We cannot redirect to "", redirect to "/" instead.
  * @param {string} path path
- * @return {string} noramlized path
+ * @returns {string} noramlized path
  */
 function normalizeRedirectPath(path) {
   return path || "/";
@@ -192,7 +192,7 @@ module.exports = function () {
  * @param {*} req the Request.
  * @param {*} res the Response.
  * @param {string} p the path to search for.
- * @return {Promise<*>} a non-null value if a file is found.
+ * @returns {Promise<*>} a non-null value if a file is found.
  */
 function providerResult(req, res, p) {
   const promises = [];

src/middleware/files.js

@@ -26,15 +26,15 @@ const onHeaders = require("on-headers");
 const patterns = require("../utils/patterns");
 
 const normalizedConfigHeaders = function (spec, config) {
-  const out = config || [];
+  const out = config ?? [];
   if (_.isArray(config)) {
     const _isAllowed = function (headerToSet) {
       return _.includes(spec.allowedHeaders, headerToSet.key.toLowerCase());
     };
 
     for (const c of config) {
       c.source = slasher(c.source);
-      c.headers = c.headers || [];
+      c.headers = c.headers ?? [];
       if (spec.allowedHeaders) {
         c.headers = c.headers.filter(_isAllowed);
       }