Make Firecracker's instance ID configurable

Firecracker's instance ID is appeared in Firecracker's log
file. Setting the ID makes the log easily trackable from clients.

Signed-off-by: Kazuyoshi Kato <[email protected]>

Author: Kazuyoshi Kato

runtime/noop_jailer.go

@@ -44,7 +44,7 @@ func newNoopJailer(ctx context.Context, logger *logrus.Entry, shimDir vm.Dir) *n
 	}
 }
 
-func (j *noopJailer) BuildJailedMachine(cfg *config.Config, machineConfig *firecracker.Config, vmID string) ([]firecracker.Opt, error) {
+func (j *noopJailer) BuildJailedMachine(cfg *config.Config, _ *firecracker.Config, vmID string) ([]firecracker.Opt, error) {
 	if len(cfg.FirecrackerBinaryPath) == 0 {
 		return []firecracker.Opt{}, nil
 	}
@@ -57,6 +57,7 @@ func (j *noopJailer) BuildJailedMachine(cfg *config.Config, machineConfig *firec
 	cmd := firecracker.VMCommandBuilder{}.
 		WithBin(cfg.FirecrackerBinaryPath).
 		WithSocketPath(relSocketPath).
+		WithArgs([]string{"--id", vmID}).
 		Build(j.ctx)
 
 	if cfg.DebugHelper.LogFirecrackerOutput() {

runtime/runc_jailer.go

@@ -451,6 +451,7 @@ func (j *runcJailer) setDefaultConfigValues(cfg *config.Config, socketPath strin
 		cmd := firecracker.VMCommandBuilder{}.
 			WithBin("/" + firecrackerFileName).
 			WithSocketPath(socketPath).
+			WithArgs([]string{"--id", j.vmID}).
 			// Don't need to pass in an actual context here as we are only building
 			// the command arguments and not actually building a command
 			Build(context.Background())