fix for e112568 - should not retry connecting if failed due to wrong auth

Author: leibale

packages/client/lib/client/index.ts

@@ -11,7 +11,7 @@ import { ScanCommandOptions } from '../commands/SCAN';
 import { HScanTuple } from '../commands/HSCAN';
 import { extendWithCommands, extendWithModulesAndScripts, LegacyCommandArguments, transformCommandArguments, transformCommandReply, transformLegacyCommandArguments } from '../commander';
 import { Pool, Options as PoolOptions, createPool } from 'generic-pool';
-import { ClientClosedError, DisconnectsClientError } from '../errors';
+import { ClientClosedError, DisconnectsClientError, AuthError } from '../errors';
 import { URL } from 'url';
 import { TcpSocketConnectOpts } from 'net';
 
@@ -219,7 +219,9 @@ export default class RedisClient<M extends RedisModules, S extends RedisScripts>
                             password: this.#options.password ?? ''
                         }),
                         { asap: true }
-                    )
+                    ).catch(err => {
+                        throw new AuthError(err.message);
+                    })
                 );
             }
 

packages/client/lib/client/socket.ts

@@ -3,7 +3,7 @@ import * as net from 'net';
 import * as tls from 'tls';
 import { encodeCommand } from '../commander';
 import { RedisCommandArguments } from '../commands';
-import { ConnectionTimeoutError, ClientClosedError, SocketClosedUnexpectedlyError } from '../errors';
+import { ConnectionTimeoutError, ClientClosedError, SocketClosedUnexpectedlyError, AuthError } from '../errors';
 import { promiseTimeout } from '../utils';
 
 export interface RedisSocketCommonOptions {
@@ -110,6 +110,11 @@ export default class RedisSocket extends EventEmitter {
             } catch (err) {
                 this.#socket.destroy();
                 this.#socket = undefined;
+
+                if (err instanceof AuthError) {
+                    this.#isOpen = false;
+                }
+
                 throw err;
             }
 

packages/client/lib/errors.ts

@@ -33,3 +33,9 @@ export class SocketClosedUnexpectedlyError extends Error {
         super('Socket closed unexpectedly');
     }
 }
+
+export class AuthError extends Error {
+    constructor(message: string) {
+        super(message);
+    }
+}