Skip to content

Commit 6bf151c

Browse files
committed
Implement changes according to review
1 parent 5687c42 commit 6bf151c

File tree

8 files changed

+13
-12
lines changed

8 files changed

+13
-12
lines changed

Src/FluentAssertions/Primitives/NullableBooleanAssertions.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,22 +119,22 @@ public AndConstraint<TAssertions> Be(bool? expected, string because = "", params
119119
}
120120

121121
/// <summary>
122-
/// Asserts that the value is not equal to the specified <paramref name="expected"/> value.
122+
/// Asserts that the value is not equal to the specified <paramref name="unexpected"/> value.
123123
/// </summary>
124-
/// <param name="expected">The expected value</param>
124+
/// <param name="unexpected">The expected value</param>
125125
/// <param name="because">
126126
/// A formatted phrase as is supported by <see cref="string.Format(string,object[])" /> explaining why the assertion
127127
/// is needed. If the phrase does not start with the word <i>because</i>, it is prepended automatically.
128128
/// </param>
129129
/// <param name="becauseArgs">
130130
/// Zero or more objects to format using the placeholders in <paramref name="because" />.
131131
/// </param>
132-
public AndConstraint<TAssertions> NotBe(bool? expected, string because = "", params object[] becauseArgs)
132+
public AndConstraint<TAssertions> NotBe(bool? unexpected, string because = "", params object[] becauseArgs)
133133
{
134134
Execute.Assertion
135-
.ForCondition(Subject != expected)
135+
.ForCondition(Subject != unexpected)
136136
.BecauseOf(because, becauseArgs)
137-
.FailWith("Expected {context:nullable boolean} not to be {0}{reason}, but found {1}.", expected, Subject);
137+
.FailWith("Expected {context:nullable boolean} not to be {0}{reason}, but found {1}.", unexpected, Subject);
138138

139139
return new AndConstraint<TAssertions>((TAssertions)this);
140140
}

Tests/Approval.Tests/ApprovedApi/FluentAssertions/net47.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1951,7 +1951,7 @@ namespace FluentAssertions.Primitives
19511951
public FluentAssertions.AndConstraint<TAssertions> Be(bool? expected, string because = "", params object[] becauseArgs) { }
19521952
public FluentAssertions.AndConstraint<TAssertions> BeNull(string because = "", params object[] becauseArgs) { }
19531953
public FluentAssertions.AndConstraint<TAssertions> HaveValue(string because = "", params object[] becauseArgs) { }
1954-
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? expected, string because = "", params object[] becauseArgs) { }
1954+
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? unexpected, string because = "", params object[] becauseArgs) { }
19551955
public FluentAssertions.AndConstraint<TAssertions> NotBeFalse(string because = "", params object[] becauseArgs) { }
19561956
public FluentAssertions.AndConstraint<TAssertions> NotBeNull(string because = "", params object[] becauseArgs) { }
19571957
public FluentAssertions.AndConstraint<TAssertions> NotBeTrue(string because = "", params object[] becauseArgs) { }

Tests/Approval.Tests/ApprovedApi/FluentAssertions/net6.0.verified.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2008,6 +2008,7 @@ namespace FluentAssertions.Primitives
20082008
public FluentAssertions.AndConstraint<TAssertions> Be(bool? expected, string because = "", params object[] becauseArgs) { }
20092009
public FluentAssertions.AndConstraint<TAssertions> BeNull(string because = "", params object[] becauseArgs) { }
20102010
public FluentAssertions.AndConstraint<TAssertions> HaveValue(string because = "", params object[] becauseArgs) { }
2011+
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? unexpected, string because = "", params object[] becauseArgs) { }
20112012
public FluentAssertions.AndConstraint<TAssertions> NotBeFalse(string because = "", params object[] becauseArgs) { }
20122013
public FluentAssertions.AndConstraint<TAssertions> NotBeNull(string because = "", params object[] becauseArgs) { }
20132014
public FluentAssertions.AndConstraint<TAssertions> NotBeTrue(string because = "", params object[] becauseArgs) { }

Tests/Approval.Tests/ApprovedApi/FluentAssertions/netcoreapp2.1.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1951,7 +1951,7 @@ namespace FluentAssertions.Primitives
19511951
public FluentAssertions.AndConstraint<TAssertions> Be(bool? expected, string because = "", params object[] becauseArgs) { }
19521952
public FluentAssertions.AndConstraint<TAssertions> BeNull(string because = "", params object[] becauseArgs) { }
19531953
public FluentAssertions.AndConstraint<TAssertions> HaveValue(string because = "", params object[] becauseArgs) { }
1954-
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? expected, string because = "", params object[] becauseArgs) { }
1954+
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? unexpected, string because = "", params object[] becauseArgs) { }
19551955
public FluentAssertions.AndConstraint<TAssertions> NotBeFalse(string because = "", params object[] becauseArgs) { }
19561956
public FluentAssertions.AndConstraint<TAssertions> NotBeNull(string because = "", params object[] becauseArgs) { }
19571957
public FluentAssertions.AndConstraint<TAssertions> NotBeTrue(string because = "", params object[] becauseArgs) { }

Tests/Approval.Tests/ApprovedApi/FluentAssertions/netcoreapp3.0.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1951,7 +1951,7 @@ namespace FluentAssertions.Primitives
19511951
public FluentAssertions.AndConstraint<TAssertions> Be(bool? expected, string because = "", params object[] becauseArgs) { }
19521952
public FluentAssertions.AndConstraint<TAssertions> BeNull(string because = "", params object[] becauseArgs) { }
19531953
public FluentAssertions.AndConstraint<TAssertions> HaveValue(string because = "", params object[] becauseArgs) { }
1954-
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? expected, string because = "", params object[] becauseArgs) { }
1954+
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? unexpected, string because = "", params object[] becauseArgs) { }
19551955
public FluentAssertions.AndConstraint<TAssertions> NotBeFalse(string because = "", params object[] becauseArgs) { }
19561956
public FluentAssertions.AndConstraint<TAssertions> NotBeNull(string because = "", params object[] becauseArgs) { }
19571957
public FluentAssertions.AndConstraint<TAssertions> NotBeTrue(string because = "", params object[] becauseArgs) { }

Tests/Approval.Tests/ApprovedApi/FluentAssertions/netstandard2.0.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1903,7 +1903,7 @@ namespace FluentAssertions.Primitives
19031903
public FluentAssertions.AndConstraint<TAssertions> Be(bool? expected, string because = "", params object[] becauseArgs) { }
19041904
public FluentAssertions.AndConstraint<TAssertions> BeNull(string because = "", params object[] becauseArgs) { }
19051905
public FluentAssertions.AndConstraint<TAssertions> HaveValue(string because = "", params object[] becauseArgs) { }
1906-
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? expected, string because = "", params object[] becauseArgs) { }
1906+
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? unexpected, string because = "", params object[] becauseArgs) { }
19071907
public FluentAssertions.AndConstraint<TAssertions> NotBeFalse(string because = "", params object[] becauseArgs) { }
19081908
public FluentAssertions.AndConstraint<TAssertions> NotBeNull(string because = "", params object[] becauseArgs) { }
19091909
public FluentAssertions.AndConstraint<TAssertions> NotBeTrue(string because = "", params object[] becauseArgs) { }

Tests/Approval.Tests/ApprovedApi/FluentAssertions/netstandard2.1.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1951,7 +1951,7 @@ namespace FluentAssertions.Primitives
19511951
public FluentAssertions.AndConstraint<TAssertions> Be(bool? expected, string because = "", params object[] becauseArgs) { }
19521952
public FluentAssertions.AndConstraint<TAssertions> BeNull(string because = "", params object[] becauseArgs) { }
19531953
public FluentAssertions.AndConstraint<TAssertions> HaveValue(string because = "", params object[] becauseArgs) { }
1954-
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? expected, string because = "", params object[] becauseArgs) { }
1954+
public FluentAssertions.AndConstraint<TAssertions> NotBe(bool? unexpected, string because = "", params object[] becauseArgs) { }
19551955
public FluentAssertions.AndConstraint<TAssertions> NotBeFalse(string because = "", params object[] becauseArgs) { }
19561956
public FluentAssertions.AndConstraint<TAssertions> NotBeNull(string because = "", params object[] becauseArgs) { }
19571957
public FluentAssertions.AndConstraint<TAssertions> NotBeTrue(string because = "", params object[] becauseArgs) { }

Tests/FluentAssertions.Specs/Primitives/NullableBooleanAssertionSpecs.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ public void When_asserting_boolean_null_value_to_be_equal_to_different_nullable_
201201
}
202202

203203
[Fact]
204-
public void When_asserting_boolean_null_value_not_to_be_equal_to_same_boolean_null_value_should_fail()
204+
public void When_asserting_boolean_null_value_not_to_be_equal_to_same_value_should_fail()
205205
{
206206
// Arrange
207207
bool? nullableBoolean = null;
@@ -232,7 +232,7 @@ public void When_asserting_boolean_null_value_to_be_equal_to_null_it_should_succ
232232
}
233233

234234
[Fact]
235-
public void When_asserting_boolean_value_not_to_be_equal_to_boolean_value_it_should_succeed()
235+
public void When_asserting_boolean_null_value_not_to_be_equal_to_different_value_it_should_succeed()
236236
{
237237
// Arrange
238238
bool? nullableBoolean = true;

0 commit comments

Comments
 (0)