-
Notifications
You must be signed in to change notification settings - Fork 17
Remove engine dependency of LifecycleChannel #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove engine dependency of LifecycleChannel #127
Conversation
3ced96a to
4f0df04
Compare
|
First of all, Thank you for your efforts to improve code. 👏 (I should do too... but it's not easy... 😄 ) In my case, I am not sure which one is better, so I referred to other implementation...but I still don't know. 😢 |
4f0df04 to
ad78711
Compare
|
There are a few more "Channel" implementations that depend on FlutterTizenEngine, and I'm planning to refactor them as well after this change. |
bbrto21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks similar to the Android implementation and In my view, this is better.
pkosko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@bbrto21 Why do you think so? I'm just curious... I want to know even a small or minor part. |
I've just seen these |
|
@bbrto21 FYI, it's also consistent with the Dart side definition of the lifecycle channel. |
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
* Remove engine dependency of LifecycleChannel * Implement StringSerializer * Remove StringSerializer and implement StringCodec
Sends lifecycle messages through a BasicMessageChannel instead of using
FlutterTizenEngine::SendPlatformMessage.I implemented
StringCodecfrom scratch because there was no equivalent of the framework'sStringCodecin cpp_client_wrapper.StandardCodecSerializeralready has support for the string data type but its serialization format is slightly different fromStringCodec's.@flutter-tizen/maintainers How do you feel about this change? I can discard this change if it doesn't make very much sense.