Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 09e27af

Browse files
[nnbd_migration] Improve dartdev migrate command for the "apply" button.
Change-Id: Ia41496401fc45cee1a00589495e0ef83d8ec6461 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138220 Commit-Queue: Mike Fairhurst <[email protected]> Reviewed-by: Samuel Rawlins <[email protected]>
1 parent d83efc3 commit 09e27af

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pkg/dartfix/lib/src/migrate/migrate.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,9 @@ class MigrateCommand extends Command {
178178
logger.stdout(
179179
'Applied ${allEdits.length} ${pluralize('edit', allEdits.length)}.');
180180

181+
// Note: do not open the web preview if apply-changes is specified, as we
182+
// currently cannot tell the web preview to disable the "apply migration"
183+
// button.
181184
return 0;
182185
}
183186

@@ -190,8 +193,8 @@ class MigrateCommand extends Command {
190193
// TODO(devoncarew): Open a browser automatically.
191194

192195
logger.stdout('');
193-
logger.stdout('To apply these changes, re-run the tool with '
194-
'--${MigrateOptions.applyChangesOption}.');
196+
logger.stdout('To apply these changes, open the web preview or re-run '
197+
'the tool with --${MigrateOptions.applyChangesOption}.');
195198

196199
logger.stdout('');
197200
logger.stdout('When finished with the preview, hit ctrl-c '

0 commit comments

Comments
 (0)