Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 49e65bd

Browse files
authored
[Impeller] Cleanly revert requiring backpressure for AHB swapchains. (#54027)
Revert 0c41729 This was a partial revert. See explanation in #54012 (comment)
1 parent f144aba commit 49e65bd

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

impeller/toolkit/android/proc_table.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ namespace impeller::android {
6060
INVOKE(ASurfaceTransaction_setBuffer, 29) \
6161
INVOKE(ASurfaceTransaction_setColor, 29) \
6262
INVOKE(ASurfaceTransaction_setOnComplete, 29) \
63-
INVOKE(ASurfaceTransaction_setEnableBackPressure, 31) \
6463
INVOKE(ASurfaceTransactionStats_getPreviousReleaseFenceFd, 29) \
6564
INVOKE(ATrace_isEnabled, 23) \
6665
INVOKE(eglGetNativeClientBufferANDROID, 0)

impeller/toolkit/android/surface_control.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include "impeller/toolkit/android/surface_control.h"
66

77
#include "impeller/base/validation.h"
8-
#include "impeller/toolkit/android/proc_table.h"
98
#include "impeller/toolkit/android/surface_transaction.h"
109

1110
namespace impeller::android {
@@ -50,8 +49,7 @@ bool SurfaceControl::RemoveFromParent() const {
5049

5150
bool SurfaceControl::IsAvailableOnPlatform() {
5251
return GetProcTable().IsValid() &&
53-
GetProcTable().ASurfaceControl_createFromWindow.IsAvailable() &&
54-
GetProcTable().ASurfaceTransaction_setEnableBackPressure.IsAvailable();
52+
GetProcTable().ASurfaceControl_createFromWindow.IsAvailable();
5553
}
5654

5755
} // namespace impeller::android

impeller/toolkit/android/surface_transaction.cc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,7 @@ bool SurfaceTransaction::SetContents(const SurfaceControl* control,
5858
VALIDATION_LOG << "Invalid control or buffer.";
5959
return false;
6060
}
61-
62-
const auto& proc_table = GetProcTable();
63-
64-
proc_table.ASurfaceTransaction_setBuffer(
61+
GetProcTable().ASurfaceTransaction_setBuffer(
6562
transaction_.get(), //
6663
control->GetHandle(), //
6764
buffer->GetHandle(), //

0 commit comments

Comments
 (0)