[dart2js] Fix type promotion bug in static_type.dart.

Change-Id: I481020289df611ed09fe4093021e875e6c4f6871
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138333
Commit-Queue: Joshua Litt <[email protected]>
Reviewed-by: Mayank Patke <[email protected]>

Author: joshualitt

pkg/compiler/lib/src/ir/static_type.dart

@@ -1013,8 +1013,11 @@ abstract class StaticTypeVisitor extends StaticTypeBase {
 
   @override
   ir.DartType visitExpressionStatement(ir.ExpressionStatement node) {
-    visitNode(node.expression);
-    return null;
+    if (completes(visitNode(node.expression))) {
+      return null;
+    } else {
+      return const DoesNotCompleteType();
+    }
   }
 
   void handleAsExpression(ir.AsExpression node, ir.DartType operandType) {}

tests/compiler/dart2js/analyses/api_allowed.json

@@ -9,21 +9,21 @@
   "org-dartlang-sdk:///sdk/lib/_internal/js_runtime/lib/js_helper.dart": {
     "Dynamic invocation of '[]'.": 3,
     "Dynamic access of 'isNaN'.": 3,
-    "Dynamic invocation of '<='.": 4,
-    "Dynamic invocation of '-'.": 4,
-    "Dynamic invocation of '>>'.": 2,
-    "Dynamic invocation of '&'.": 3,
-    "Dynamic invocation of '<'.": 3,
-    "Dynamic invocation of '>'.": 2,
+    "Dynamic invocation of '<='.": 2,
+    "Dynamic invocation of '-'.": 3,
+    "Dynamic invocation of '&'.": 1,
+    "Dynamic invocation of '>>'.": 1,
+    "Dynamic invocation of '<'.": 2,
     "Dynamic invocation of '+'.": 1,
+    "Dynamic invocation of '>'.": 1,
     "Dynamic access of 'length'.": 1
   },
   "org-dartlang-sdk:///sdk/lib/_internal/js_runtime/lib/string_helper.dart": {
     "Dynamic invocation of '<'.": 1,
     "Dynamic invocation of '+'.": 1,
     "Dynamic invocation of '>='.": 1,
     "Dynamic invocation of 'substring'.": 7,
-    "Dynamic invocation of 'allMatches'.": 4,
+    "Dynamic invocation of 'allMatches'.": 3,
     "Dynamic access of 'isNotEmpty'.": 1,
     "Dynamic invocation of '_js_helper::_execGlobal'.": 1,
     "Dynamic access of 'start'.": 1,