Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 77c5812

Browse files
author
Nurhan Turgut
authored
[web] Skipping failing edge tests (#16626)
* making edge default test browser on windows. adding some skips (not all) for methods failing on edge * skip failing tests. make egde default for testing * skip one more test * addressing reviewer comments. removing extra bat file
1 parent 46d341c commit 77c5812

File tree

11 files changed

+229
-92
lines changed

11 files changed

+229
-92
lines changed

lib/web_ui/dev/felt_windows.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ IF %orTempValue%==0 (
5757
:: TODO(nurhan): The batch script does not support snanphot option.
5858
:: Support snapshot option.
5959
CALL :installdeps
60-
%DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %*
60+
IF %1==test (%DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* --browser=edge) ELSE ( %DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* )
6161

6262
EXIT /B 0
6363

lib/web_ui/test/dom_renderer_test.dart

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@ void main() {
9999
expect(parent.innerHtml, '<a></a><b></b><c></c><d></d>');
100100
});
101101

102-
test('inneheight/innerWidth are equal to visualViewport height and width', () {
102+
test('innerHeight/innerWidth are equal to visualViewport height and width',
103+
() {
103104
if (html.window.visualViewport != null) {
104105
expect(html.window.visualViewport.width, html.window.innerWidth);
105106
expect(html.window.visualViewport.height, html.window.innerHeight);
@@ -115,13 +116,16 @@ void main() {
115116

116117
final DomRenderer renderer = DomRenderer();
117118
renderer.reset();
118-
}, // TODO(nurhan): https://github.com/flutter/flutter/issues/46638
119-
skip: (browserEngine == BrowserEngine.firefox));
119+
},
120+
// TODO(nurhan): https://github.com/flutter/flutter/issues/46638
121+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50828
122+
skip: (browserEngine == BrowserEngine.firefox ||
123+
browserEngine == BrowserEngine.edge));
120124

121125
test('accesibility placeholder is attached after creation', () {
122126
DomRenderer();
123127

124128
expect(html.document.getElementsByTagName('flt-semantics-placeholder'),
125-
isNotEmpty);
129+
isNotEmpty);
126130
});
127131
}

lib/web_ui/test/engine/history_test.dart

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ void main() {
5656

5757
// The flutter entry is the current entry.
5858
expect(strategy.currentEntry, flutterEntry);
59-
});
59+
},
60+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
61+
skip: browserEngine == BrowserEngine.edge);
6062

6163
test('browser back button pops routes correctly', () async {
6264
strategy =
@@ -90,7 +92,9 @@ void main() {
9092
// The url of the current entry (flutter entry) should go back to /home.
9193
expect(strategy.currentEntry.state, flutterState);
9294
expect(strategy.currentEntry.url, '/home');
93-
});
95+
},
96+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
97+
skip: browserEngine == BrowserEngine.edge);
9498

9599
test('multiple browser back clicks', () async {
96100
strategy =
@@ -151,7 +155,9 @@ void main() {
151155
// 3. The active entry doesn't belong to our history anymore because we
152156
// navigated past it.
153157
expect(strategy.currentEntryIndex, -1);
154-
});
158+
},
159+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
160+
skip: browserEngine == BrowserEngine.edge);
155161

156162
test('handle user-provided url', () async {
157163
strategy =
@@ -190,7 +196,9 @@ void main() {
190196
expect(strategy.currentEntryIndex, 1);
191197
expect(strategy.currentEntry.state, flutterState);
192198
expect(strategy.currentEntry.url, '/home');
193-
});
199+
},
200+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
201+
skip: browserEngine == BrowserEngine.edge);
194202

195203
test('user types unknown url', () async {
196204
strategy =
@@ -212,7 +220,9 @@ void main() {
212220
expect(strategy.currentEntryIndex, 1);
213221
expect(strategy.currentEntry.state, flutterState);
214222
expect(strategy.currentEntry.url, '/home');
215-
});
223+
},
224+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
225+
skip: browserEngine == BrowserEngine.edge);
216226
});
217227
}
218228

lib/web_ui/test/engine/semantics/semantics_helper_test.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ void main() {
6363
desktopSemanticsEnabler.tryEnableSemantics(event);
6464

6565
expect(shouldForwardToFramework, true);
66-
});
66+
},
67+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
68+
skip: browserEngine == BrowserEngine.edge);
6769

6870
test(
6971
'Relevants events targeting placeholder should not be forwarded to the framework',
@@ -149,7 +151,7 @@ void main() {
149151
},
150152
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
151153
// TODO(nurhan): https://github.com/flutter/flutter/issues/46638
152-
skip: (browserEngine == BrowserEngine.firefox ||
153-
browserEngine == BrowserEngine.webkit));
154+
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
155+
skip: browserEngine != BrowserEngine.blink);
154156
});
155157
}

0 commit comments

Comments
 (0)