Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 78b4717

Browse files
dogbenSkia Commit-Bot
authored andcommitted
[infra] fix recipe bug
We shouldn't modify self.m.vars.extra_tokens in the docker flavor. I noticed this when doing some debugging. It doesn't seem to be causing any problems currently. Change-Id: I2239787f8aec8a25a6a26418c633e68840f74e04 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/271058 Commit-Queue: Eric Boren <[email protected]> Auto-Submit: Ben Wagner aka dogben <[email protected]> Reviewed-by: Eric Boren <[email protected]>
1 parent 4af17e4 commit 78b4717

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

infra/bots/recipe_modules/flavor/docker.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ def _map_host_path_to_docker(self, path):
3939
return None
4040

4141
def step(self, name, cmd, **unused_kwargs):
42-
extra_tokens = self.m.vars.extra_tokens
43-
extra_tokens.remove('Docker')
42+
extra_tokens = [t for t in self.m.vars.extra_tokens if t != 'Docker']
4443
os = self.m.vars.builder_cfg.get('os', '')
4544
model = self.m.vars.builder_cfg.get('model', '')
4645
cpu_or_gpu = self.m.vars.builder_cfg.get('cpu_or_gpu', '')

0 commit comments

Comments
 (0)