[CFE] Add ability to compare CompilerOptions

This is (intended to be) a small step towards removing the batch compiler.

Change-Id: I201c56b6d33420f91d2f4b989682670cd8d6a387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138508
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: jensjoha

pkg/compiler/lib/src/kernel/dart2js_target.dart

@@ -50,6 +50,7 @@ bool maybeEnableNative(Uri uri) {
 
 /// A kernel [Target] to configure the Dart Front End for dart2js.
 class Dart2jsTarget extends Target {
+  @override
   final TargetFlags flags;
   @override
   final String name;

pkg/dev_compiler/lib/src/kernel/target.dart

@@ -23,6 +23,7 @@ import 'kernel_helpers.dart';
 class DevCompilerTarget extends Target {
   DevCompilerTarget(this.flags);
 
+  @override
   final TargetFlags flags;
 
   WidgetCreatorTracker _widgetTracker;

pkg/front_end/lib/src/api_prototype/compiler_options.dart

@@ -25,6 +25,8 @@ import 'file_system.dart' show FileSystem;
 
 import 'standard_file_system.dart' show StandardFileSystem;
 
+import '../api_unstable/util.dart';
+
 export 'package:_fe_analyzer_shared/src/messages/diagnostic_message.dart'
     show DiagnosticMessage;
 
@@ -102,7 +104,7 @@ class CompilerOptions {
   /// When this option is `true`, [sdkSummary] must be null.
   bool compileSdk = false;
 
-  @deprecated
+  @Deprecated("Unused internally.")
   bool chaseDependencies;
 
   /// Patch files to apply on the core libraries for a specific target platform.
@@ -119,6 +121,7 @@ class CompilerOptions {
   /// directly, while relative URIs are resolved from the [sdkRoot].
   // TODO(sigmund): provide also a flag to load this data from a file (like
   // libraries.json)
+  @Deprecated("Unused internally.")
   Map<String, List<Uri>> targetPatches = <String, List<Uri>>{};
 
   /// Enable or disable experimental features. Features mapping to `true` are
@@ -153,6 +156,7 @@ class CompilerOptions {
 
   /// Deprecated. Has no affect on front-end.
   // TODO(dartbug.com/37514) Remove this field once DDK removes its uses of it.
+  @Deprecated("Unused internally.")
   bool enableAsserts = false;
 
   /// Whether to show verbose messages (mainly for debugging and performance
@@ -232,6 +236,65 @@ class CompilerOptions {
   String currentSdkVersion = "${kernel.defaultLanguageVersionMajor}"
       "."
       "${kernel.defaultLanguageVersionMinor}";
+
+  bool equivalent(CompilerOptions other,
+      {bool ignoreOnDiagnostic: true,
+      bool ignoreVerbose: true,
+      bool ignoreVerify: true,
+      bool ignoreDebugDump: true}) {
+    if (sdkRoot != other.sdkRoot) return false;
+    if (librariesSpecificationUri != other.librariesSpecificationUri) {
+      return false;
+    }
+    if (!ignoreOnDiagnostic) {
+      if (onDiagnostic != other.onDiagnostic) return false;
+    }
+    if (packagesFileUri != other.packagesFileUri) return false;
+    if (!equalLists(additionalDills, other.additionalDills)) return false;
+    if (sdkSummary != other.sdkSummary) return false;
+    if (!equalMaps(declaredVariables, other.declaredVariables)) return false;
+    if (fileSystem != other.fileSystem) return false;
+    if (compileSdk != compileSdk) return false;
+    // chaseDependencies aren't used anywhere, so ignored here.
+    // targetPatches aren't used anywhere, so ignored here.
+    if (!equalMaps(experimentalFlags, other.experimentalFlags)) return false;
+    if (!equalMaps(environmentDefines, other.environmentDefines)) return false;
+    if (errorOnUnevaluatedConstant != other.errorOnUnevaluatedConstant) {
+      return false;
+    }
+    if (target != other.target) {
+      if (target.runtimeType != other.target.runtimeType) return false;
+      if (target.name != other.target.name) return false;
+      if (target.flags != other.target.flags) return false;
+    }
+    // enableAsserts is not used anywhere, so ignored here.
+    if (!ignoreVerbose) {
+      if (verbose != other.verbose) return false;
+    }
+    if (!ignoreVerify) {
+      if (verify != other.verify) return false;
+    }
+    if (!ignoreDebugDump) {
+      if (debugDump != other.debugDump) return false;
+    }
+    if (omitPlatform != other.omitPlatform) return false;
+    if (setExitCodeOnProblem != other.setExitCodeOnProblem) return false;
+    if (embedSourceText != other.embedSourceText) return false;
+    if (throwOnErrorsForDebugging != other.throwOnErrorsForDebugging) {
+      return false;
+    }
+    if (throwOnWarningsForDebugging != other.throwOnWarningsForDebugging) {
+      return false;
+    }
+    if (skipForDebugging != other.skipForDebugging) return false;
+    if (bytecode != other.bytecode) return false;
+    if (writeFileOnCrashReport != other.writeFileOnCrashReport) return false;
+    if (nnbdMode != other.nnbdMode) return false;
+    if (performNnbdChecks != other.performNnbdChecks) return false;
+    if (currentSdkVersion != other.currentSdkVersion) return false;
+
+    return true;
+  }
 }
 
 /// Parse experimental flag arguments of the form 'flag' or 'no-flag' into a map

pkg/kernel/lib/target/targets.dart

@@ -22,6 +22,32 @@ class TargetFlags {
       this.forceLateLoweringForTesting = false,
       this.forceNoExplicitGetterCallsForTesting = false,
       this.enableNullSafety = false});
+
+  bool operator ==(other) {
+    if (other is! TargetFlags) return false;
+    TargetFlags o = other;
+    if (trackWidgetCreation != o.trackWidgetCreation) return false;
+    if (forceLateLoweringForTesting != o.forceLateLoweringForTesting) {
+      return false;
+    }
+    if (forceNoExplicitGetterCallsForTesting !=
+        o.forceNoExplicitGetterCallsForTesting) {
+      return false;
+    }
+    if (enableNullSafety != o.enableNullSafety) return false;
+    return true;
+  }
+
+  int get hashCode {
+    int hash = 485786;
+    hash = 0x3fffffff & (hash * 31 + (hash ^ trackWidgetCreation.hashCode));
+    hash = 0x3fffffff &
+        (hash * 31 + (hash ^ forceLateLoweringForTesting.hashCode));
+    hash = 0x3fffffff &
+        (hash * 31 + (hash ^ forceNoExplicitGetterCallsForTesting.hashCode));
+    hash = 0x3fffffff & (hash * 31 + (hash ^ enableNullSafety.hashCode));
+    return hash;
+  }
 }
 
 typedef Target _TargetBuilder(TargetFlags flags);
@@ -87,6 +113,7 @@ class ConstantsBackend {
 
 /// A target provides backend-specific options for generating kernel IR.
 abstract class Target {
+  TargetFlags get flags;
   String get name;
 
   /// A list of URIs of required libraries, not including dart:core.

pkg/vm/bin/kernel_service.dart

@@ -139,7 +139,6 @@ abstract class Compiler {
           parseExperimentalArguments(expFlags),
           onError: (msg) => errors.add(msg))
       ..environmentDefines = new EnvironmentMap()
-      ..enableAsserts = enableAsserts
       ..nnbdMode = nullSafety ? NnbdMode.Strong : NnbdMode.Weak
       ..onDiagnostic = (DiagnosticMessage message) {
         bool printMessage;