Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit fbb7d3a

Browse files
jmagmanjmagman
authored
[ci] Replace Firebase Test Lab deprecated Pixel 4 device with Pixel 5 (#4436)
1 parent aae841a commit fbb7d3a

File tree

4 files changed

+20
-19
lines changed

4 files changed

+20
-19
lines changed

‎.cirrus.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ task:
214214
- export CIRRUS_COMMIT_MESSAGE=""
215215
- if [[ -n "$GCLOUD_FIREBASE_TESTLAB_KEY" ]]; then
216216
- echo $GCLOUD_FIREBASE_TESTLAB_KEY > ${HOME}/gcloud-service-key.json
217-
- ./script/tool_runner.sh firebase-test-lab --device model=flame,version=29 --device model=starqlteue,version=26 --exclude=script/configs/exclude_integration_android.yaml
217+
- ./script/tool_runner.sh firebase-test-lab --device model=redfin,version=30 --device model=starqlteue,version=26 --exclude=script/configs/exclude_integration_android.yaml
218218
- else
219219
- echo "This user does not have permission to run Firebase Test Lab tests."
220220
- fi

‎script/tool/CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## NEXT
22

3+
- Update Firebase Testlab deprecated test device. (Pixel 4 API 29 -> Pixel 5 API 30).
34
- `native-test --android`, `--ios`, and `--macos` now fail plugins that don't
45
have unit tests, rather than skipping them.
56
- Added a new `federation-safety-check` command to help catch changes to

‎script/tool/lib/src/firebase_test_lab_command.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class FirebaseTestLabCommand extends PackageLoopingCommand {
5454
splitCommas: false,
5555
defaultsTo: <String>[
5656
'model=walleye,version=26',
57-
'model=flame,version=29'
57+
'model=redfin,version=30'
5858
],
5959
help:
6060
'Device model(s) to test. See https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run for more info');

‎script/tool/test/firebase_test_lab_command_test.dart‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ void main() {
101101
final List<String> output = await runCapturingPrint(runner, <String>[
102102
'firebase-test-lab',
103103
'--device',
104-
'model=flame,version=29',
104+
'model=redfin,version=30',
105105
'--device',
106106
'model=seoul,version=26',
107107
'--test-run-id',
@@ -142,7 +142,7 @@ void main() {
142142
'/packages/plugin1/example/android'),
143143
ProcessCall(
144144
'gcloud',
145-
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin1/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
145+
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin1/buildId/testRunId/0/ --device model=redfin,version=30 --device model=seoul,version=26'
146146
.split(' '),
147147
'/packages/plugin1/example'),
148148
ProcessCall(
@@ -156,7 +156,7 @@ void main() {
156156
'/packages/plugin2/example/android'),
157157
ProcessCall(
158158
'gcloud',
159-
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin2/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
159+
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin2/buildId/testRunId/0/ --device model=redfin,version=30 --device model=seoul,version=26'
160160
.split(' '),
161161
'/packages/plugin2/example'),
162162
]),
@@ -176,7 +176,7 @@ void main() {
176176
final List<String> output = await runCapturingPrint(runner, <String>[
177177
'firebase-test-lab',
178178
'--device',
179-
'model=flame,version=29',
179+
'model=redfin,version=30',
180180
'--device',
181181
'model=seoul,version=26',
182182
'--test-run-id',
@@ -219,7 +219,7 @@ void main() {
219219
'/packages/plugin/example/android'),
220220
ProcessCall(
221221
'gcloud',
222-
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
222+
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=redfin,version=30 --device model=seoul,version=26'
223223
.split(' '),
224224
'/packages/plugin/example'),
225225
ProcessCall(
@@ -229,7 +229,7 @@ void main() {
229229
'/packages/plugin/example/android'),
230230
ProcessCall(
231231
'gcloud',
232-
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/1/ --device model=flame,version=29 --device model=seoul,version=26'
232+
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/1/ --device model=redfin,version=30 --device model=seoul,version=26'
233233
.split(' '),
234234
'/packages/plugin/example'),
235235
]),
@@ -257,7 +257,7 @@ void main() {
257257
<String>[
258258
'firebase-test-lab',
259259
'--device',
260-
'model=flame,version=29',
260+
'model=redfin,version=30',
261261
'--device',
262262
'model=seoul,version=26',
263263
'--test-run-id',
@@ -294,7 +294,7 @@ void main() {
294294
<String>[
295295
'firebase-test-lab',
296296
'--device',
297-
'model=flame,version=29',
297+
'model=redfin,version=30',
298298
'--device',
299299
'model=seoul,version=26',
300300
'--test-run-id',
@@ -332,7 +332,7 @@ void main() {
332332
<String>[
333333
'firebase-test-lab',
334334
'--device',
335-
'model=flame,version=29',
335+
'model=redfin,version=30',
336336
'--device',
337337
'model=seoul,version=26',
338338
'--test-run-id',
@@ -366,7 +366,7 @@ void main() {
366366
final List<String> output = await runCapturingPrint(runner, <String>[
367367
'firebase-test-lab',
368368
'--device',
369-
'model=flame,version=29',
369+
'model=redfin,version=30',
370370
'--device',
371371
'model=seoul,version=26',
372372
'--test-run-id',
@@ -400,7 +400,7 @@ void main() {
400400
final List<String> output = await runCapturingPrint(runner, <String>[
401401
'firebase-test-lab',
402402
'--device',
403-
'model=flame,version=29',
403+
'model=redfin,version=30',
404404
'--device',
405405
'model=seoul,version=26',
406406
'--test-run-id',
@@ -445,7 +445,7 @@ void main() {
445445
'/packages/plugin/example/android'),
446446
ProcessCall(
447447
'gcloud',
448-
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=flame,version=29 --device model=seoul,version=26'
448+
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=redfin,version=30 --device model=seoul,version=26'
449449
.split(' '),
450450
'/packages/plugin/example'),
451451
]),
@@ -468,7 +468,7 @@ void main() {
468468
<String>[
469469
'firebase-test-lab',
470470
'--device',
471-
'model=flame,version=29',
471+
'model=redfin,version=30',
472472
],
473473
errorHandler: (Error e) {
474474
commandError = e;
@@ -505,7 +505,7 @@ void main() {
505505
<String>[
506506
'firebase-test-lab',
507507
'--device',
508-
'model=flame,version=29',
508+
'model=redfin,version=30',
509509
],
510510
errorHandler: (Error e) {
511511
commandError = e;
@@ -543,7 +543,7 @@ void main() {
543543
<String>[
544544
'firebase-test-lab',
545545
'--device',
546-
'model=flame,version=29',
546+
'model=redfin,version=30',
547547
],
548548
errorHandler: (Error e) {
549549
commandError = e;
@@ -571,7 +571,7 @@ void main() {
571571
await runCapturingPrint(runner, <String>[
572572
'firebase-test-lab',
573573
'--device',
574-
'model=flame,version=29',
574+
'model=redfin,version=30',
575575
'--test-run-id',
576576
'testRunId',
577577
'--build-id',
@@ -601,7 +601,7 @@ void main() {
601601
'/packages/plugin/example/android'),
602602
ProcessCall(
603603
'gcloud',
604-
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=flame,version=29'
604+
'firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --results-bucket=gs://flutter_firebase_testlab --results-dir=plugins_android_test/plugin/buildId/testRunId/0/ --device model=redfin,version=30'
605605
.split(' '),
606606
'/packages/plugin/example'),
607607
]),

0 commit comments

Comments
 (0)