-
Notifications
You must be signed in to change notification settings - Fork 0
fix(eslint-config-fuf): update dependency eslint-plugin-react-hooks to v6 #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Needs ReviewI recommend reviewing this upgrade before merging because it introduces two critical breaking changes: a Node.js version requirement bump to v18+ and a migration from legacy ESLint config to flat config format. While this project already uses ESLint flat config (eslint.config.mjs), the plugin now defaults to 'recommended' instead of 'recommended-legacy', and the codebase imports the plugin directly without using any recommended preset configuration. Additionally, there's a reported issue with v6.x unexpectedly installing 37 Babel dependencies even for projects not using Babel, which could significantly bloat the dependency tree. Manual review is needed to verify Node.js compatibility, confirm the flat config setup works correctly with the new default, and assess the impact of the Babel dependency bloat. What we checked
Dependency UsageThis dependency is a development tool used exclusively within the eslint-config-fuf package to enforce React Hooks linting rules. It is integrated into the React ESLint configuration preset exported by this package, enabling projects that consume this configuration to automatically validate proper usage of React Hooks patterns (such as ensuring hooks are called in the correct order and only within function components). The plugin operates as part of the code quality infrastructure rather than supporting direct business functionality, providing automated developer guardrails during the development process. ChangesBREAKING: eslint-plugin-react-hooks now requires Node.js 18+ and switches to flat config as the default recommended preset (legacy config moved to
View 7 more changes
References (5)[1]: eslint-plugin-react-hooks upgraded to 6.1.0 which requires Node.js 18+ and changes default config preset
[2]: Plugin registered manually in flat config without using recommended preset - needs verification that this approach still works correctly with v6.x breaking changes
[3]: Project uses ESLint flat config format which is required for v6.x compatibility ts-project-setup/eslint.config.mjs Line 7 in cefcb55
[4]: Version 6.x installs 37 additional Babel dependencies even for projects not using Babel or React compiler, significantly bloating dependency tree (source link) [5]: Official migration guide documents flat config changes and new preset naming (recommended vs recommended-legacy) (source link) fossabot analyzed this PR using dependency research. |
77f8ff3 to
761cfce
Compare
761cfce to
9e38c5c
Compare
|



Note
Mend has cancelled the proposed renaming of the Renovate GitHub app being renamed to
mend[bot].This notice will be removed on 2025-10-07.
This PR contains the following updates:
5.2.0->6.1.1Release Notes
facebook/react (eslint-plugin-react-hooks)
v6.1.1Compare Source
Note: 6.1.0 accidentally allowed use of
recommendedwithout flat config, causing errors when used with ESLint v9'sdefineConfig()helper. This has been fixed in 6.1.1.recommendedconfig for flat config compatibility. Therecommendedconfig has been converted to flat config format. Non-flat config users should userecommended-legacyinstead. (@poteto in #34700)recommended-latestandrecommended-latest-legacyconfigs that include React Compiler rules. (@poteto in #34675)NoUnusedOptOutDirectivesrule. (@poteto in #34703)hermes-parserand dependency. (@poteto in #34719)@babel/plugin-proposal-private-methodsdependency. (@ArnaudBarre and @josephsavona in #34715)v6.1.0Compare Source
Note: Version 6.0.0 was mistakenly released and immediately deprecated and untagged on npm. This is the first official 6.x major release and includes breaking changes.
recommendedpreset. Legacy config moved torecommended-legacy. (@michaelfaith in #32457)usewithin try/catch blocks. (@poteto in #34040)useEffectEventfunctions in arbitrary closures. (@jbrown215 in #33544)React.useEffectin addition touseEffectin rules-of-hooks. (@Ayc0 in #34076)react-hookssettings config option that to acceptadditionalEffectHooksthat are used across exhaustive-deps and rules-of-hooks rules. (@jbrown215) in #34497v6.0.0Compare Source
Accidentally released. See 6.1.0 for the actual changes.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.