linter issues

Author: vaind

flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplayBreadcrumbConverter.kt

@@ -8,6 +8,8 @@ import io.sentry.rrweb.RRWebSpanEvent
 import java.util.Date
 
 private const val MILLIS_PER_SECOND = 1000.0
+private const val MAX_PATH_ITEMS = 4
+private const val MAX_PATH_IDENTIFIER_LENGTH = 20
 
 class SentryFlutterReplayBreadcrumbConverter : DefaultReplayBreadcrumbConverter() {
   internal companion object {
@@ -85,16 +87,12 @@ class SentryFlutterReplayBreadcrumbConverter : DefaultReplayBreadcrumbConverter(
   }
 
   private fun getTouchPathMessage(maybePath: Any?): String? {
-    if (maybePath !is List<*>) {
-      return null
-    }
-
-    if (maybePath.isEmpty()) {
+    if (maybePath !is List<*> || maybePath.isEmpty()) {
       return null
     }
 
     val message = StringBuilder()
-    for (i in Math.min(3, maybePath.size - 1) downTo 0) {
+    for (i in Math.min(MAX_PATH_ITEMS, maybePath.size) - 1 downTo 0) {
       val item = maybePath[i]
       if (item !is Map<*, *>) {
         continue
@@ -104,8 +102,8 @@ class SentryFlutterReplayBreadcrumbConverter : DefaultReplayBreadcrumbConverter(
 
       var identifier = item["label"] ?: item["name"]
       if (identifier is String && identifier.isNotEmpty()) {
-        if (identifier.length > 20) {
-          identifier = identifier.substring(0, 17) + "..."
+        if (identifier.length > MAX_PATH_IDENTIFIER_LENGTH) {
+          identifier = identifier.substring(0, MAX_PATH_IDENTIFIER_LENGTH - "...".length) + "..."
         }
         message.append("(").append(identifier).append(")")
       }

flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterReplayRecorder.kt

@@ -12,7 +12,7 @@ internal class SentryFlutterReplayRecorder(
   private val channel: MethodChannel,
   private val integration: ReplayIntegration,
 ) : Recorder {
-  override fun start(config: ScreenshotRecorderConfig) {
+  override fun start(recorderConfig: ScreenshotRecorderConfig) {
     val cacheDirPath = integration.replayCacheDir?.absolutePath
     if (cacheDirPath == null) {
       Log.w("Sentry", "Replay cache directory is null, can't start replay recorder.")
@@ -24,9 +24,9 @@ internal class SentryFlutterReplayRecorder(
           "ReplayRecorder.start",
           mapOf(
             "directory" to cacheDirPath,
-            "width" to config.recordingWidth,
-            "height" to config.recordingHeight,
-            "frameRate" to config.frameRate,
+            "width" to recorderConfig.recordingWidth,
+            "height" to recorderConfig.recordingHeight,
+            "frameRate" to recorderConfig.frameRate,
             "replayId" to integration.getReplayId().toString(),
           ),
         )