Fixes setting the correct locale to contexts with navigatorKey #1724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
Contributor
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ae02632 | 309.16 ms | 348.98 ms | 39.82 ms |
| b728df4 | 390.98 ms | 445.81 ms | 54.83 ms |
| 11fb408 | 320.10 ms | 380.24 ms | 60.14 ms |
| 5603ab2 | 309.84 ms | 345.20 ms | 35.36 ms |
| 3e5ee37 | 317.56 ms | 366.84 ms | 49.28 ms |
| d53c6fa | 282.83 ms | 344.00 ms | 61.17 ms |
| 8cb6557 | 321.20 ms | 370.46 ms | 49.26 ms |
| b47809a | 333.42 ms | 368.36 ms | 34.95 ms |
| eecbbca | 324.37 ms | 352.49 ms | 28.12 ms |
| 3a69405 | 334.34 ms | 369.19 ms | 34.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ae02632 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| b728df4 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 11fb408 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
| 5603ab2 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 3e5ee37 | 5.94 MiB | 6.92 MiB | 1001.19 KiB |
| d53c6fa | 6.16 MiB | 7.14 MiB | 1011.18 KiB |
| 8cb6557 | 6.06 MiB | 7.03 MiB | 997.01 KiB |
| b47809a | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| eecbbca | 5.94 MiB | 6.89 MiB | 975.78 KiB |
| 3a69405 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
ueman
reviewed
Nov 13, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1724 +/- ##
==========================================
- Coverage 91.35% 91.09% -0.27%
==========================================
Files 68 164 +96
Lines 2442 5334 +2892
==========================================
+ Hits 2231 4859 +2628
- Misses 211 475 +264 ☔ View full report in Codecov by Sentry. |
ueman
approved these changes
Nov 14, 2023
Contributor
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7e30648 | 1241.43 ms | 1255.76 ms | 14.33 ms |
| f0fcbe1 | 1238.08 ms | 1243.44 ms | 5.36 ms |
| 9d43f71 | 1225.06 ms | 1227.06 ms | 2.00 ms |
| a7acb24 | 1296.71 ms | 1317.69 ms | 20.98 ms |
| d783424 | 1265.71 ms | 1277.00 ms | 11.29 ms |
| 3e33891 | 6245.86 ms | 6260.90 ms | 15.04 ms |
| 211a7aa | 1258.02 ms | 1275.65 ms | 17.63 ms |
| a2ec542 | 1258.33 ms | 1267.20 ms | 8.88 ms |
| 22ed6cb | 1277.41 ms | 1283.76 ms | 6.35 ms |
| c1bb00f | 1265.14 ms | 1290.85 ms | 25.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7e30648 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| f0fcbe1 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| 9d43f71 | 8.29 MiB | 9.39 MiB | 1.10 MiB |
| a7acb24 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| d783424 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| 3e33891 | 8.29 MiB | 9.38 MiB | 1.09 MiB |
| 211a7aa | 8.10 MiB | 9.18 MiB | 1.08 MiB |
| a2ec542 | 8.10 MiB | 9.14 MiB | 1.05 MiB |
| 22ed6cb | 8.10 MiB | 9.17 MiB | 1.08 MiB |
| c1bb00f | 8.09 MiB | 9.07 MiB | 1001.06 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Setting screen locale is not properly reflected in contexts
💡 Motivation and Context
Fixes #1410
💚 How did you test it?
Unit test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps
Add docs