Skip to content

Refactor AssemblyReaders to allow different logging levels #4382

@jamescrosswell

Description

@jamescrosswell

The code we vendored in to create the Android Assembly Readers currently uses a DebugLogger delegate:

public delegate void DebugLogger(string message, params object?[] args);

The existing delegate doesn't have any notion of "log levels", so is a bit limited.

We can't use our IDiagnosticLogger, since this would create a circular reference. However we can add a DebugLoggerLevel enum and use this as the first parameter to the DebugLogger delegate.

Originally posted by @jamescrosswell in #4294 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    .NETPull requests that update .net code

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions