Skip to content

Commit 14abbb1

Browse files
committed
ref(gatsby): Default release to empty string
To make gatsby work better out of the box, we set the default for the release value to be undefined instead of an empty string.
1 parent 8ea6c9d commit 14abbb1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/gatsby/gatsby-node.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const sentryRelease = JSON.stringify(
1111
process.env.ZEIT_GITHUB_COMMIT_SHA ||
1212
process.env.ZEIT_GITLAB_COMMIT_SHA ||
1313
process.env.ZEIT_BITBUCKET_COMMIT_SHA ||
14-
'',
14+
undefined,
1515
);
1616

1717
const sentryDsn = JSON.stringify(process.env.SENTRY_DSN || '');

packages/gatsby/test/gatsby-node.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe('onCreateWebpackConfig', () => {
1818
expect(plugins.define).toHaveBeenCalledTimes(1);
1919
expect(plugins.define).toHaveBeenLastCalledWith({
2020
__SENTRY_DSN__: expect.any(String),
21-
__SENTRY_RELEASE__: expect.any(String),
21+
__SENTRY_RELEASE__: undefined,
2222
});
2323

2424
expect(actions.setWebpackConfig).toHaveBeenCalledTimes(1);

0 commit comments

Comments
 (0)