Add unsafe any rule

Author: AbhiPrasad

.eslintrc.js

@@ -93,6 +93,11 @@ module.exports = {
 
         // We should prevent against overloads unless necessary.
         '@typescript-eslint/unified-signatures': 'error',
+
+        // Disallow unsafe any usage. We should enforce that types be used as possible, or unknown be used
+        // instead of any. This is especially important for methods that expose a public API, as users
+        // should know exactly what they have to provide to use those methods. Turned off in tests.
+        '@typescript-eslint/no-unsafe-member-access': 'error',
       },
     },
     {
@@ -125,6 +130,7 @@ module.exports = {
         '@typescript-eslint/explicit-function-return-type': 'off',
         'no-unused-expressions': 'off',
         '@typescript-eslint/no-unused-expressions': 'off',
+        '@typescript-eslint/no-unsafe-member-access': 'off',
       },
     },
     {

packages/angular/src/tracing.ts

@@ -146,6 +146,7 @@ export class TraceDirective implements OnInit, AfterViewInit {
 export function TraceClassDecorator(): ClassDecorator {
   let tracingSpan: Span;
 
+  /* eslint-disable @typescript-eslint/no-unsafe-member-access */
   // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
   return target => {
     const originalOnInit = target.prototype.ngOnInit;
@@ -174,6 +175,7 @@ export function TraceClassDecorator(): ClassDecorator {
       }
     };
   };
+  /* eslint-enable @typescript-eslint/no-unsafe-member-access */
 }
 
 /**
@@ -196,6 +198,7 @@ export function TraceMethodDecorator(): MethodDecorator {
         });
       }
       if (originalMethod) {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
         return originalMethod.apply(this, args);
       }
     };

packages/apm/src/integrations/tracing.ts

@@ -630,6 +630,7 @@ export class Tracing implements Integration {
     let entryScriptStartEndTime: number | undefined;
     let tracingInitMarkStartTime: number | undefined;
 
+    /* eslint-disable @typescript-eslint/no-unsafe-member-access */
     performance
       .getEntries()
       .slice(Tracing._performanceCursor)
@@ -687,6 +688,7 @@ export class Tracing implements Integration {
           // Ignore other entry types.
         }
       });
+    /* eslint-enable @typescript-eslint/no-unsafe-member-access */
 
     if (entryScriptStartEndTime !== undefined && tracingInitMarkStartTime !== undefined) {
       _startChild(transactionSpan, {
@@ -771,6 +773,7 @@ export class Tracing implements Integration {
     return time / 1000;
   }
 
+  /* eslint-disable @typescript-eslint/no-unsafe-member-access */
   /**
    * Adds debug data to the span
    */
@@ -792,6 +795,7 @@ export class Tracing implements Integration {
     debugData['Date.now()'] = Date.now();
     span.setData('sentry_debug', debugData);
   }
+  /* eslint-enable @typescript-eslint/no-unsafe-member-access */
 
   /**
    * @inheritDoc
@@ -934,6 +938,7 @@ export class Tracing implements Integration {
   }
 }
 
+/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /**
  * Creates breadcrumbs from XHR API calls
  */
@@ -1038,6 +1043,7 @@ function fetchCallback(handlerData: { [key: string]: any }): void {
     }
   }
 }
+/* eslint-enable @typescript-eslint/no-unsafe-member-access */
 
 /**
  * Creates transaction from navigation changes

packages/browser/.eslintrc.js

@@ -24,6 +24,7 @@ module.exports = {
         'max-lines': 'off',
         'prefer-template': 'off',
         'no-unused-expressions': 'off',
+        'guard-for-in': 'off',
       },
     },
     {

packages/browser/src/helpers.ts

@@ -69,14 +69,15 @@ export function wrap(
         before.apply(this, arguments);
       }
 
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
       const wrappedArguments = args.map((arg: any) => wrap(arg, options));
 
       if (fn.handleEvent) {
         // Attempt to invoke user-land function
         // NOTE: If you are a Sentry user, and you are seeing this stack frame, it
         //       means the sentry.javascript SDK caught an error invoking your application code. This
         //       is expected behavior and NOT indicative of a bug with sentry.javascript.
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
         return fn.handleEvent.apply(this, wrappedArguments);
       }
       // Attempt to invoke user-land function

packages/browser/src/integrations/breadcrumbs.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable max-lines */
 import { getCurrentHub } from '@sentry/core';
 import { Event, Integration, Severity } from '@sentry/types';

packages/browser/src/integrations/globalhandlers.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unsafe-member-access */
 import { getCurrentHub } from '@sentry/core';
 import { Event, Integration, Severity } from '@sentry/types';
 import {

packages/browser/src/integrations/trycatch.ts

@@ -125,6 +125,7 @@ export class TryCatch implements Integration {
   private _wrapRAF(original: any): (callback: () => void) => any {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     return function(this: any, callback: () => void): () => void {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
       return original.call(
         this,
         wrap(callback, {
@@ -145,8 +146,10 @@ export class TryCatch implements Integration {
   private _wrapEventTarget(target: string): void {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const global = getGlobalObject() as { [key: string]: any };
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
     const proto = global[target] && global[target].prototype;
 
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
     if (!proto || !proto.hasOwnProperty || !proto.hasOwnProperty('addEventListener')) {
       return;
     }

packages/browser/src/tracekit.ts

@@ -3,6 +3,8 @@
  * largely modified and is now maintained as part of Sentry JS SDK.
  */
 
+/* eslint-disable @typescript-eslint/no-unsafe-member-access */
+
 /**
  * An object representing a single stack frame.
  * {Object} StackFrame

packages/core/src/baseclient.ts

@@ -330,6 +330,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
     // so this block overwrites the normalized event to add back the original
     // Transaction information prior to normalization.
     if (event.contexts && event.contexts.trace) {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
       normalized.contexts.trace = event.contexts.trace;
     }
     return normalized;