Skip to content

Commit e62e50c

Browse files
committed
fix: follow span op conventions
1 parent 69c9142 commit e62e50c

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

dev-packages/e2e-tests/test-applications/nuxt-3/tests/middleware.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test.describe('Server Middleware Instrumentation', () => {
1717
const serverTxnEvent = await serverTxnEventPromise;
1818

1919
// Verify that we have spans for each middleware
20-
const middlewareSpans = serverTxnEvent.spans?.filter(span => span.op === 'http.server.middleware') || [];
20+
const middlewareSpans = serverTxnEvent.spans?.filter(span => span.op === 'middleware.nuxt') || [];
2121

2222
expect(middlewareSpans).toHaveLength(3);
2323

@@ -34,9 +34,9 @@ test.describe('Server Middleware Instrumentation', () => {
3434
[firstMiddlewareSpan, secondMiddlewareSpan, authMiddlewareSpan].forEach(span => {
3535
expect(span).toEqual(
3636
expect.objectContaining({
37-
op: 'http.server.middleware',
37+
op: 'middleware.nuxt',
3838
data: expect.objectContaining({
39-
'sentry.op': 'http.server.middleware',
39+
'sentry.op': 'middleware.nuxt',
4040
'sentry.origin': 'auto.http.nuxt',
4141
'sentry.source': 'custom',
4242
'http.request.method': 'GET',
@@ -68,7 +68,7 @@ test.describe('Server Middleware Instrumentation', () => {
6868
await request.get('/api/middleware-test');
6969
const serverTxnEvent = await serverTxnEventPromise;
7070

71-
const middlewareSpans = serverTxnEvent.spans?.filter(span => span.op === 'http.server.middleware') || [];
71+
const middlewareSpans = serverTxnEvent.spans?.filter(span => span.op === 'middleware.nuxt') || [];
7272

7373
// All middleware spans should be children of the main transaction
7474
middlewareSpans.forEach(span => {
@@ -95,7 +95,7 @@ test.describe('Server Middleware Instrumentation', () => {
9595

9696
// Find the auth middleware span
9797
const authMiddlewareSpan = serverTxnEvent.spans?.find(
98-
span => span.op === 'http.server.middleware' && span.data?.['nuxt.middleware.name'] === '03.auth.ts',
98+
span => span.op === 'middleware.nuxt' && span.data?.['nuxt.middleware.name'] === '03.auth.ts',
9999
);
100100

101101
expect(authMiddlewareSpan).toBeDefined();

dev-packages/e2e-tests/test-applications/nuxt-4/tests/middleware.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test.describe('Server Middleware Instrumentation', () => {
1717
const serverTxnEvent = await serverTxnEventPromise;
1818

1919
// Verify that we have spans for each middleware
20-
const middlewareSpans = serverTxnEvent.spans?.filter(span => span.op === 'http.server.middleware') || [];
20+
const middlewareSpans = serverTxnEvent.spans?.filter(span => span.op === 'middleware.nuxt') || [];
2121

2222
expect(middlewareSpans).toHaveLength(3);
2323

@@ -34,9 +34,9 @@ test.describe('Server Middleware Instrumentation', () => {
3434
[firstMiddlewareSpan, secondMiddlewareSpan, authMiddlewareSpan].forEach(span => {
3535
expect(span).toEqual(
3636
expect.objectContaining({
37-
op: 'http.server.middleware',
37+
op: 'middleware.nuxt',
3838
data: expect.objectContaining({
39-
'sentry.op': 'http.server.middleware',
39+
'sentry.op': 'middleware.nuxt',
4040
'sentry.origin': 'auto.http.nuxt',
4141
'sentry.source': 'custom',
4242
'http.request.method': 'GET',
@@ -68,7 +68,7 @@ test.describe('Server Middleware Instrumentation', () => {
6868
await request.get('/api/middleware-test');
6969
const serverTxnEvent = await serverTxnEventPromise;
7070

71-
const middlewareSpans = serverTxnEvent.spans?.filter(span => span.op === 'http.server.middleware') || [];
71+
const middlewareSpans = serverTxnEvent.spans?.filter(span => span.op === 'middleware.nuxt') || [];
7272

7373
// All middleware spans should be children of the main transaction
7474
middlewareSpans.forEach(span => {
@@ -95,7 +95,7 @@ test.describe('Server Middleware Instrumentation', () => {
9595

9696
// Find the auth middleware span
9797
const authMiddlewareSpan = serverTxnEvent.spans?.find(
98-
span => span.op === 'http.server.middleware' && span.data?.['nuxt.middleware.name'] === '03.auth.ts',
98+
span => span.op === 'middleware.nuxt' && span.data?.['nuxt.middleware.name'] === '03.auth.ts',
9999
);
100100

101101
expect(authMiddlewareSpan).toBeDefined();

packages/nuxt/src/runtime/hooks/wrapMiddlewareHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export function wrapMiddlewareHandler(handler: EventHandler, fileName: string) {
5959
*/
6060
function getSpanAttributes(event: H3Event<EventHandlerRequest>, fileName: string): SpanAttributes {
6161
const attributes: SpanAttributes = {
62-
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'http.server.middleware',
62+
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'middleware.nuxt',
6363
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'custom',
6464
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.nuxt',
6565
'nuxt.middleware.name': fileName,

0 commit comments

Comments
 (0)