feat(on-demand): Add feature flag check before cardinality check (#98726)

Some users are experiencing high latency due to this cardinality check.
Since metrics extraction for widgets has paused and we're in the process
of migrating users to spans/EAP, I figured we could avoid running this
check for users that do not have the feature flag if we're not planning
to continue rolling it out.

Author: narsaynorath

src/sentry/tasks/on_demand_metrics.py

@@ -8,7 +8,7 @@
 from celery.exceptions import SoftTimeLimitExceeded
 from django.utils import timezone
 
-from sentry import options
+from sentry import features, options
 from sentry.models.dashboard_widget import (
     DashboardWidgetQuery,
     DashboardWidgetQueryOnDemand,
@@ -423,6 +423,9 @@ def check_field_cardinality(
     is_task: bool = False,
     widget_query: DashboardWidgetQuery | None = None,
 ) -> dict[str, str]:
+    if not features.has("organizations:on-demand-metrics-extraction-widgets", organization):
+        return {}
+
     if not query_columns:
         return {}
     if is_task:

tests/sentry/dashboards/endpoints/test_organization_dashboard_details.py

@@ -3121,7 +3121,7 @@ def test_ondemand_updates_new_widget(self, mock_query: mock.MagicMock) -> None:
             assert current_version.extraction_state == "enabled:creation"
 
     @mock.patch("sentry.tasks.on_demand_metrics._query_cardinality")
-    def test_cardinality_precedence_over_feature_checks(self, mock_query: mock.MagicMock) -> None:
+    def test_cardinality_check_with_feature_flag(self, mock_query: mock.MagicMock) -> None:
         mock_query.return_value = {"data": [{"count_unique(sometag)": 1_000_000}]}, [
             "sometag",
         ]
@@ -3145,7 +3145,9 @@ def test_cardinality_precedence_over_feature_checks(self, mock_query: mock.Magic
                 },
             ],
         }
-        response = self.do_request("put", self.url(self.dashboard.id), data=data)
+
+        with self.feature(["organizations:on-demand-metrics-extraction-widgets"]):
+            response = self.do_request("put", self.url(self.dashboard.id), data=data)
         assert response.status_code == 200, response.data
         widgets = self.get_widgets(self.dashboard.id)
         assert len(widgets) == 1
@@ -3160,6 +3162,48 @@ def test_cardinality_precedence_over_feature_checks(self, mock_query: mock.Magic
             assert current_version is not None
             assert current_version.extraction_state == "disabled:high-cardinality"
 
+    @mock.patch("sentry.tasks.on_demand_metrics._query_cardinality")
+    def test_feature_check_takes_precedence_over_cardinality(
+        self, mock_query: mock.MagicMock
+    ) -> None:
+        mock_query.return_value = {"data": [{"count_unique(sometag)": 1_000_000}]}, [
+            "sometag",
+        ]
+        data: dict[str, Any] = {
+            "title": "first dashboard",
+            "widgets": [
+                {
+                    "title": "errors per project",
+                    "displayType": "table",
+                    "interval": "5m",
+                    "widgetType": DashboardWidgetTypes.get_type_name(self.widget_type),
+                    "queries": [
+                        {
+                            "name": "errors",
+                            "fields": ["count()", "sometag"],
+                            "columns": ["sometag"],
+                            "aggregates": ["count()"],
+                            "conditions": "event.type:transaction",
+                        }
+                    ],
+                },
+            ],
+        }
+        response = self.do_request("put", self.url(self.dashboard.id), data=data)
+        assert response.status_code == 200, response.data
+        widgets = self.get_widgets(self.dashboard.id)
+        assert len(widgets) == 1
+        last = list(widgets).pop()
+        queries = last.dashboardwidgetquery_set.all()
+
+        ondemand_objects = DashboardWidgetQueryOnDemand.objects.filter(
+            dashboard_widget_query=queries[0]
+        )
+        for version in OnDemandMetricSpecVersioning.get_spec_versions():
+            current_version = ondemand_objects.filter(spec_version=version.version).first()
+            assert current_version is not None
+            assert current_version.extraction_state == "disabled:pre-rollout"
+
     @mock.patch("sentry.api.serializers.rest_framework.dashboard.get_current_widget_specs")
     def test_cardinality_skips_non_discover_widget_types(
         self, mock_get_specs: mock.MagicMock