Skip to content

Commit 26ea0eb

Browse files
lobsterkatielobsterkatie
committed
add group hash to seer data and request params in tests
1 parent 39a17bb commit 26ea0eb

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

‎tests/sentry/api/endpoints/test_group_similar_issues_embeddings.py‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -662,12 +662,14 @@ def test_get_formatted_results(self):
662662
similar_issue_data_1 = SeerSimilarIssueData(
663663
message_distance=0.05,
664664
parent_group_id=NonNone(self.similar_event.group_id),
665+
parent_group_hash=NonNone(self.similar_event.get_primary_hash()),
665666
should_group=True,
666667
stacktrace_distance=0.01,
667668
)
668669
similar_issue_data_2 = SeerSimilarIssueData(
669670
message_distance=0.49,
670671
parent_group_id=NonNone(event_from_second_similar_group.group_id),
672+
parent_group_hash=NonNone(event_from_second_similar_group.get_primary_hash()),
671673
should_group=False,
672674
stacktrace_distance=0.23,
673675
)
@@ -718,6 +720,7 @@ def test_simple_only_group_id_returned(self, mock_logger, mock_seer_request):
718720

719721
expected_seer_request_params = {
720722
"group_id": self.group.id,
723+
"group_hash": NonNone(self.event.get_primary_hash()),
721724
"project_id": self.project.id,
722725
"stacktrace": EXPECTED_STACKTRACE_STRING,
723726
"message": self.group.message,
@@ -764,6 +767,7 @@ def test_simple_only_hash_returned(self, mock_logger, mock_seer_request):
764767

765768
expected_seer_request_params = {
766769
"group_id": self.group.id,
770+
"group_hash": NonNone(self.event.get_primary_hash()),
767771
"project_id": self.project.id,
768772
"stacktrace": EXPECTED_STACKTRACE_STRING,
769773
"message": self.group.message,
@@ -812,6 +816,7 @@ def test_simple_group_id_and_hash_returned(self, mock_logger, mock_seer_request)
812816

813817
expected_seer_request_params = {
814818
"group_id": self.group.id,
819+
"group_hash": NonNone(self.event.get_primary_hash()),
815820
"project_id": self.project.id,
816821
"stacktrace": EXPECTED_STACKTRACE_STRING,
817822
"message": self.group.message,
@@ -843,18 +848,21 @@ def test_multiple(self, mock_seer_request, mock_record):
843848
{
844849
"message_distance": 0.05,
845850
"parent_group_id": NonNone(self.similar_event.group_id),
851+
"parent_group_hash": NonNone(self.similar_event.get_primary_hash()),
846852
"should_group": True,
847853
"stacktrace_distance": 0.002, # Over threshold
848854
},
849855
{
850856
"message_distance": 0.05,
851857
"parent_group_id": NonNone(over_threshold_group_event.group_id),
858+
"parent_group_hash": NonNone(over_threshold_group_event.get_primary_hash()),
852859
"should_group": True,
853860
"stacktrace_distance": 0.002, # Over threshold
854861
},
855862
{
856863
"message_distance": 0.05,
857864
"parent_group_id": NonNone(under_threshold_group_event.group_id),
865+
"parent_group_hash": NonNone(under_threshold_group_event.get_primary_hash()),
858866
"should_group": False,
859867
"stacktrace_distance": 0.05, # Under threshold
860868
},
@@ -883,6 +891,7 @@ def test_multiple(self, mock_seer_request, mock_record):
883891
organization_id=self.org.id,
884892
project_id=self.project.id,
885893
group_id=self.group.id,
894+
group_hash=NonNone(self.event.get_primary_hash()),
886895
count_over_threshold=2,
887896
user_id=self.user.id,
888897
)
@@ -898,6 +907,7 @@ def test_incomplete_return_data(self, mock_seer_request, mock_logger):
898907
{
899908
"message_distance": 0.05,
900909
"parent_group_id": NonNone(self.similar_event.group_id),
910+
"parent_group_hash": NonNone(self.similar_event.get_primary_hash()),
901911
"should_group": True,
902912
"stacktrace_distance": 0.01,
903913
},
@@ -917,6 +927,7 @@ def test_incomplete_return_data(self, mock_seer_request, mock_logger):
917927
extra={
918928
"request_params": {
919929
"group_id": NonNone(self.event.group_id),
930+
"group_hash": NonNone(self.event.get_primary_hash()),
920931
"project_id": self.project.id,
921932
"stacktrace": EXPECTED_STACKTRACE_STRING,
922933
"message": self.group.message,
@@ -947,12 +958,14 @@ def test_nonexistent_group(self, mock_seer_request, mock_logger):
947958
{
948959
"message_distance": 0.05,
949960
"parent_group_id": NonNone(self.similar_event.group_id),
961+
"parent_group_hash": NonNone(self.similar_event.get_primary_hash()),
950962
"should_group": True,
951963
"stacktrace_distance": 0.01,
952964
},
953965
{
954966
"message_distance": 0.05,
955967
"parent_group_id": 1121201212312012, # too high to be real
968+
"parent_group_hash": "not a real hash",
956969
"should_group": True,
957970
"stacktrace_distance": 0.01,
958971
},
@@ -966,13 +979,15 @@ def test_nonexistent_group(self, mock_seer_request, mock_logger):
966979
extra={
967980
"request_params": {
968981
"group_id": NonNone(self.event.group_id),
982+
"group_hash": NonNone(self.event.get_primary_hash()),
969983
"project_id": self.project.id,
970984
"stacktrace": EXPECTED_STACKTRACE_STRING,
971985
"message": self.group.message,
972986
},
973987
"raw_similar_issue_data": {
974988
"message_distance": 0.05,
975989
"parent_group_id": 1121201212312012,
990+
"parent_group_hash": "not a real hash",
976991
"should_group": True,
977992
"stacktrace_distance": 0.01,
978993
},
@@ -995,6 +1010,7 @@ def test_empty_seer_return(self, mock_seer_request, mock_record):
9951010
organization_id=self.org.id,
9961011
project_id=self.project.id,
9971012
group_id=self.group.id,
1013+
group_hash=NonNone(self.event.get_primary_hash()),
9981014
count_over_threshold=0,
9991015
user_id=self.user.id,
10001016
)
@@ -1063,6 +1079,7 @@ def test_no_optional_params(self, mock_seer_request):
10631079
{
10641080
"message_distance": 0.05,
10651081
"parent_group_id": NonNone(self.similar_event.group_id),
1082+
"parent_group_hash": NonNone(self.similar_event.get_primary_hash()),
10661083
"should_group": True,
10671084
"stacktrace_distance": 0.01,
10681085
}
@@ -1083,6 +1100,7 @@ def test_no_optional_params(self, mock_seer_request):
10831100
body=json.dumps(
10841101
{
10851102
"group_id": self.group.id,
1103+
"group_hash": NonNone(self.event.get_primary_hash()),
10861104
"project_id": self.project.id,
10871105
"stacktrace": EXPECTED_STACKTRACE_STRING,
10881106
"message": self.group.message,
@@ -1106,6 +1124,7 @@ def test_no_optional_params(self, mock_seer_request):
11061124
body=json.dumps(
11071125
{
11081126
"group_id": self.group.id,
1127+
"group_hash": NonNone(self.event.get_primary_hash()),
11091128
"project_id": self.project.id,
11101129
"stacktrace": EXPECTED_STACKTRACE_STRING,
11111130
"message": self.group.message,
@@ -1130,6 +1149,7 @@ def test_no_optional_params(self, mock_seer_request):
11301149
body=json.dumps(
11311150
{
11321151
"group_id": self.group.id,
1152+
"group_hash": NonNone(self.event.get_primary_hash()),
11331153
"project_id": self.project.id,
11341154
"stacktrace": EXPECTED_STACKTRACE_STRING,
11351155
"message": self.group.message,

‎tests/sentry/seer/test_utils.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ def test_simple_similar_issues_embeddings_only_group_id_returned(
8080

8181
params: SimilarIssuesEmbeddingsRequest = {
8282
"group_id": NonNone(event.group_id),
83+
"group_hash": NonNone(event.get_primary_hash()),
8384
"project_id": default_project.id,
8485
"stacktrace": "string",
8586
"message": "message",
@@ -106,6 +107,7 @@ def test_simple_similar_issues_embeddings_only_hash_returned(mock_seer_request,
106107

107108
params: SimilarIssuesEmbeddingsRequest = {
108109
"group_id": NonNone(event.group_id),
110+
"group_hash": NonNone(event.get_primary_hash()),
109111
"project_id": default_project.id,
110112
"stacktrace": "string",
111113
"message": "message",
@@ -142,6 +144,7 @@ def test_simple_similar_issues_embeddings_both_returned(mock_seer_request, defau
142144

143145
params: SimilarIssuesEmbeddingsRequest = {
144146
"group_id": NonNone(event.group_id),
147+
"group_hash": NonNone(event.get_primary_hash()),
145148
"project_id": default_project.id,
146149
"stacktrace": "string",
147150
"message": "message",
@@ -160,6 +163,7 @@ def test_empty_similar_issues_embeddings(mock_seer_request, default_project):
160163

161164
params: SimilarIssuesEmbeddingsRequest = {
162165
"group_id": NonNone(event.group_id),
166+
"group_hash": NonNone(event.get_primary_hash()),
163167
"project_id": default_project.id,
164168
"stacktrace": "string",
165169
"message": "message",

0 commit comments

Comments
 (0)