ref: remove remote_subscriptions migrations

this is a noop now and after the last hard stop already

Author: asottile-sentry

migrations_lockfile.txt

@@ -19,8 +19,6 @@ monitors: 0005_record_date_in_progress_state
 
 nodestore: 0002_nodestore_no_dictfield
 
-remote_subscriptions: 0003_drop_remote_subscription
-
 replays: 0005_drop_replay_index
 
 sentry: 0904_onboarding_task_project_id_idx

pyproject.toml

@@ -350,7 +350,6 @@ module = [
     "sentry.release_health.release_monitor.*",
     "sentry.relocation.api.endpoints.artifacts.*",
     "sentry.relocation.services.relocation_export.*",
-    "sentry.remote_subscriptions.migrations.*",
     "sentry.replays.consumers.*",
     "sentry.replays.lib.new_query.*",
     "sentry.replays.migrations.*",

src/sentry/conf/server.py

@@ -3202,7 +3202,6 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]:
     "social_auth",
     "feedback",
     "hybridcloud",
-    "remote_subscriptions",
     "uptime",
     "workflow_engine",
     "tempest",

src/sentry/remote_subscriptions/migrations/0001_remote_subscription.py

@@ -27,7 +27,6 @@ class Migration(CheckedMigration):
     initial = True
 
     dependencies = [
-        ("remote_subscriptions", "0001_remote_subscription"),
         ("sentry", "0731_add_insight_project_flags"),
     ]
 
@@ -41,14 +40,6 @@ class Migration(CheckedMigration):
                         primary_key=True, serialize=False
                     ),
                 ),
-                (
-                    "remote_subscription",
-                    sentry.db.models.fields.foreignkey.FlexibleForeignKey(
-                        on_delete=django.db.models.deletion.CASCADE,
-                        to="remote_subscriptions.remotesubscription",
-                        unique=True,
-                    ),
-                ),
                 ("url", models.CharField(max_length=255)),
                 ("interval_seconds", models.IntegerField()),
                 ("timeout_ms", models.IntegerField()),

src/sentry/remote_subscriptions/migrations/0002_remove_separate_remote_subscription.py

@@ -1,9 +1,7 @@
 # Generated by Django 5.0.6 on 2024-06-21 17:10
 
-import django.db.models.deletion
 from django.db import migrations, models
 
-import sentry.db.models.fields.foreignkey
 from sentry.new_migrations.migrations import CheckedMigration
 from sentry.new_migrations.monkey.special import SafeRunSQL
 
@@ -25,16 +23,11 @@ class Migration(CheckedMigration):
 
     dependencies = [
         ("uptime", "0001_uptime_subscriptions"),
-        ("remote_subscriptions", "0001_remote_subscription"),
     ]
 
     operations = [
         migrations.SeparateDatabaseAndState(
             state_operations=[
-                migrations.RemoveField(
-                    model_name="uptimesubscription",
-                    name="remote_subscription",
-                ),
                 migrations.AddField(
                     model_name="uptimesubscription",
                     name="type",
@@ -48,16 +41,6 @@ class Migration(CheckedMigration):
                 ),
             ],
             database_operations=[
-                migrations.AlterField(
-                    model_name="uptimesubscription",
-                    name="remote_subscription",
-                    field=sentry.db.models.fields.foreignkey.FlexibleForeignKey(
-                        null=True,
-                        on_delete=django.db.models.deletion.CASCADE,
-                        to="remote_subscriptions.remotesubscription",
-                        unique=True,
-                    ),
-                ),
                 SafeRunSQL(
                     """
                     ALTER TABLE "uptime_uptimesubscription" ADD COLUMN "type" text NOT NULL;

src/sentry/remote_subscriptions/migrations/0003_drop_remote_subscription.py

@@ -1,6 +1,5 @@
 # Generated by Django 5.0.6 on 2024-06-21 22:03
 from sentry.new_migrations.migrations import CheckedMigration
-from sentry.new_migrations.monkey.special import SafeRunSQL
 
 
 class Migration(CheckedMigration):
@@ -22,14 +21,4 @@ class Migration(CheckedMigration):
         ("uptime", "0002_remove_separate_remote_subscription"),
     ]
 
-    operations = [
-        SafeRunSQL(
-            """
-                    ALTER TABLE "uptime_uptimesubscription" DROP COLUMN "remote_subscription_id";
-                    """,
-            reverse_sql="""
-                    ALTER TABLE "uptime_uptimesubscription" ADD COLUMN "remote_subscription_id" bigint NULL;
-                    """,
-            hints={"tables": ["uptime_uptimesubscription"]},
-        )
-    ]
+    operations = []