chore(issues): Expand stronger typing enforcement for issues

Author: mrduncan

pyproject.toml

@@ -577,6 +577,10 @@ module = [
     "sentry.buffer.base",
     "sentry.buffer.redis",
     "sentry.eventstore.reprocessing.redis",
+    "sentry.grouping.ingest.metrics",
+    "sentry.grouping.ingest.utils",
+    "sentry.grouping.strategies",
+    "sentry.grouping.strategies.message",
     "sentry.issues.analytics",
     "sentry.issues.apps",
     "sentry.issues.constants",
@@ -609,6 +613,7 @@ module = [
     "sentry.issues.update_inbox",
     "sentry.lang.java.processing",
     "sentry.llm.*",
+    "sentry.mediators.token_exchange.util",
     "sentry.migrations.*",
     "sentry.nodestore.base",
     "sentry.nodestore.bigtable.backend",
@@ -620,6 +625,7 @@ module = [
     "sentry.reprocessing2",
     "sentry.runner.*",
     "sentry.snuba.metrics.extraction",
+    "sentry.tasks.auto_remove_inbox",
     "sentry.tasks.commit_context",
     "sentry.tasks.on_demand_metrics",
     "sentry.tasks.reprocessing2",

src/sentry/grouping/api.py

@@ -96,7 +96,7 @@ def get_config_dict(self, project: Project) -> GroupingConfig:
             "enhancements": self._get_enhancements(project),
         }
 
-    def _get_enhancements(self, project) -> str:
+    def _get_enhancements(self, project: Project) -> str:
         enhancements = project.get_option("sentry:grouping_enhancements")
 
         config_id = self._get_config_id(project)
@@ -121,14 +121,14 @@ def _get_enhancements(self, project) -> str:
         cache.set(cache_key, rv)
         return rv
 
-    def _get_config_id(self, project):
+    def _get_config_id(self, project: Project):
         raise NotImplementedError
 
 
 class ProjectGroupingConfigLoader(GroupingConfigLoader):
     option_name: str  # Set in subclasses
 
-    def _get_config_id(self, project):
+    def _get_config_id(self, project: Project):
         return project.get_option(
             self.option_name,
             validate=lambda x: x in CONFIGURATIONS,
@@ -154,7 +154,7 @@ class BackgroundGroupingConfigLoader(GroupingConfigLoader):
 
     cache_prefix = "background-grouping-enhancements:"
 
-    def _get_config_id(self, project):
+    def _get_config_id(self, project: Project):
         return options.get("store.background-grouping-config-id")
 
 
@@ -176,7 +176,7 @@ def get_grouping_config_dict_for_event_data(data, project) -> GroupingConfig:
     return data.get("grouping_config") or get_grouping_config_dict_for_project(project)
 
 
-def get_default_enhancements(config_id=None) -> str:
+def get_default_enhancements(config_id: str | None = None) -> str:
     base: str | None = DEFAULT_GROUPING_ENHANCEMENTS_BASE
     if config_id is not None:
         base = CONFIGURATIONS[config_id].enhancements_base
@@ -200,7 +200,7 @@ def get_projects_default_fingerprinting_bases(
     return bases
 
 
-def get_default_grouping_config_dict(config_id=None) -> GroupingConfig:
+def get_default_grouping_config_dict(config_id: str | None = None) -> GroupingConfig:
     """Returns the default grouping config."""
     if config_id is None:
         from sentry.projectoptions.defaults import DEFAULT_GROUPING_CONFIG
@@ -257,7 +257,7 @@ def get_fingerprinting_config_for_project(
     return rv
 
 
-def apply_server_fingerprinting(event, config, allow_custom_title=True):
+def apply_server_fingerprinting(event, config, allow_custom_title=True) -> None:
     client_fingerprint = event.get("fingerprint")
     rv = config.get_fingerprint_values_for_event(event)
     if rv is not None:
@@ -419,7 +419,9 @@ def sort_grouping_variants(variants: dict[str, BaseVariant]) -> tuple[KeyedVaria
     return flat_variants, hierarchical_variants
 
 
-def detect_synthetic_exception(event_data: NodeData, loaded_grouping_config: StrategyConfiguration):
+def detect_synthetic_exception(
+    event_data: NodeData, loaded_grouping_config: StrategyConfiguration
+) -> None:
     """Detect synthetic exception and write marker to event data
 
     This only runs if detect_synthetic_exception_types is True, so

src/sentry/grouping/component.py

@@ -176,5 +176,5 @@ def as_dict(self):
                 rv["values"].append(value)
         return rv
 
-    def __repr__(self):
+    def __repr__(self) -> str:
         return f"GroupingComponent({self.id!r}, hint={self.hint!r}, contributes={self.contributes!r}, values={self.values!r})"

src/sentry/grouping/enhancer/actions.py

@@ -40,7 +40,7 @@ def update_frame_components_contributions(
     ) -> None:
         pass
 
-    def modify_stacktrace_state(self, state, rule):
+    def modify_stacktrace_state(self, state, rule) -> None:
         pass
 
     @property

src/sentry/grouping/enhancer/matchers.py

@@ -304,7 +304,7 @@ def __init__(self, inner: FrameMatch):
     def description(self) -> str:
         return f"[ {self.inner.description} ] |"
 
-    def _to_config_structure(self, version):
+    def _to_config_structure(self, version) -> str:
         return f"[{self.inner._to_config_structure(version)}]|"
 
     def matches_frame(self, frames, idx, exception_data, cache):
@@ -319,7 +319,7 @@ def __init__(self, inner: FrameMatch):
     def description(self) -> str:
         return f"| [ {self.inner.description} ]"
 
-    def _to_config_structure(self, version):
+    def _to_config_structure(self, version) -> str:
         return f"|[{self.inner._to_config_structure(version)}]"
 
     def matches_frame(self, frames, idx, exception_data, cache):

src/sentry/grouping/ingest/metrics.py

@@ -27,7 +27,7 @@ def record_hash_calculation_metrics(
     primary_hashes: CalculatedHashes,
     secondary_config: GroupingConfig,
     secondary_hashes: CalculatedHashes,
-):
+) -> None:
     has_secondary_hashes = len(extract_hashes(secondary_hashes)) > 0
 
     if has_secondary_hashes:
@@ -93,7 +93,7 @@ def record_calculation_metric_with_result(
     metrics.incr("grouping.total_calculations", amount=2 if has_secondary_hashes else 1, tags=tags)
 
 
-def record_new_group_metrics(event: Event):
+def record_new_group_metrics(event: Event) -> None:
     metrics.incr(
         "group.created",
         skip_internal=True,

src/sentry/grouping/ingest/utils.py

@@ -40,7 +40,7 @@ def add_group_id_to_grouphashes(
     ).update(group=group)
 
 
-def check_for_group_creation_load_shed(project: Project, event: Event):
+def check_for_group_creation_load_shed(project: Project, event: Event) -> None:
     """
     Raise a `HashDiscarded` error if the load-shed killswitch is enabled
     """

src/sentry/grouping/strategies/__init__.py

@@ -1,4 +1,4 @@
-def _import_all():
+def _import_all() -> None:
     # The import order here is important due to cross dependencies
     strategy_modules = [
         "message",

src/sentry/grouping/strategies/message.py

@@ -8,6 +8,7 @@
 from typing import Any
 
 import tiktoken
+from tiktoken.core import Encoding
 
 from sentry import analytics
 from sentry.eventstore.models import Event
@@ -167,7 +168,7 @@
 
 # UniqID logic
 @lru_cache(maxsize=1)
-def tiktoken_encoding():
+def tiktoken_encoding() -> Encoding:
     return tiktoken.get_encoding("cl100k_base")
 
 

src/sentry/grouping/utils.py

@@ -15,18 +15,18 @@ def parse_fingerprint_var(value):
         return match.group(1)
 
 
-def is_default_fingerprint_var(value):
+def is_default_fingerprint_var(value) -> bool:
     return parse_fingerprint_var(value) == "default"
 
 
-def hash_from_values(values):
+def hash_from_values(values) -> str:
     result = md5()
     for value in values:
         result.update(force_bytes(value, errors="replace"))
     return result.hexdigest()
 
 
-def get_rule_bool(value):
+def get_rule_bool(value: str):
     if value:
         value = value.lower()
         if value in ("1", "yes", "true"):