feat(trace-explorer): Supports metrics min/max

Metrics allow selecting a region on the graph to bound the date selection as
well as min/max. Date selection can be supported via the existing params but
this adds a metricsMin and metricsMax param to support the metrics bounds.

Author: Zylphrex

src/sentry/api/endpoints/organization_traces.py

@@ -6,6 +6,7 @@
 from datetime import datetime, timedelta
 from typing import Any, Literal, NotRequired, TypedDict, cast
 
+import sentry_sdk
 from rest_framework import serializers
 from rest_framework.exceptions import ParseError
 from rest_framework.request import Request
@@ -66,6 +67,8 @@ class OrganizationTracesSerializer(serializers.Serializer):
     )
     field = serializers.ListField(required=True, allow_empty=False, child=serializers.CharField())
     sort = serializers.ListField(required=False, allow_empty=True, child=serializers.CharField())
+    metricsMax = serializers.FloatField(required=False)
+    metricsMin = serializers.FloatField(required=False)
     metricsQuery = serializers.CharField(required=False)
     mri = serializers.CharField(required=False)
     query = serializers.ListField(
@@ -107,6 +110,8 @@ def get(self, request: Request, organization: Organization) -> Response:
             # Filter out empty queries as they do not do anything to change the results.
             user_queries=[query.strip() for query in serialized.get("query", []) if query.strip()],
             suggested_query=serialized.get("suggestedQuery", ""),
+            metrics_max=serialized.get("metricsMax"),
+            metrics_min=serialized.get("metricsMin"),
             metrics_query=serialized.get("metricsQuery", ""),
             mri=serialized.get("mri"),
             sort=serialized.get("sort"),
@@ -148,6 +153,8 @@ def __init__(
         fields: list[str],
         user_queries: list[str],
         suggested_query: str,
+        metrics_max: float | None,
+        metrics_min: float | None,
         metrics_query: str,
         mri: str | None,
         sort: str | None,
@@ -163,6 +170,8 @@ def __init__(
         self.fields = fields
         self.user_queries = user_queries
         self.suggested_query = suggested_query
+        self.metrics_max = metrics_max
+        self.metrics_min = metrics_min
         self.metrics_query = metrics_query
         self.mri = mri
         self.sort = sort
@@ -326,6 +335,8 @@ def get_traces_matching_metric_conditions(
             params=params,
             snuba_params=snuba_params,
             fields=["trace"],
+            max=self.metrics_max,
+            min=self.metrics_min,
             query=self.metrics_query,
             referrer=Referrer.API_TRACE_EXPLORER_METRICS_SPANS_LIST,
         )
@@ -674,6 +685,23 @@ def process_final_results(
             for row in suggested_spans_results["data"]:
                 traces_suggested_spans[row["trace"]].append(row)
 
+        for row in traces_metas_results["data"]:
+            if not traces_user_spans[row["trace"]]:
+                context = {
+                    "trace": row["trace"],
+                    "start": row["first_seen()"],
+                    "end": row["last_seen()"],
+                    "params": self.params,
+                    "user_query": self.user_queries,
+                    "mri": self.mri,
+                    "metrics_query": self.metrics_query,
+                    "metrics_min": self.metrics_min,
+                    "metrics_max": self.metrics_max,
+                }
+                sentry_sdk.capture_message(
+                    "trace missing spans", contexts={"trace_missing_spans": context}
+                )
+
         return [
             {
                 "trace": row["trace"],
@@ -696,6 +724,7 @@ def process_final_results(
                 ],
             }
             for row in traces_metas_results["data"]
+            if traces_user_spans[row["trace"]]
         ]
 
     def process_meta_results(self, results):
@@ -1120,6 +1149,7 @@ def stack_clear(trace, until=None):
             precise_end,
             traces_range[trace],
         )
+
         row["precise.start_ts"] = precise_start
         row["precise.finish_ts"] = precise_end
         row["quantized.start_ts"] = quantized_start

tests/sentry/api/endpoints/test_organization_traces.py

@@ -194,6 +194,7 @@ def create_mock_traces(self):
             timestamp=timestamps[-1],
             transaction="qux",
             duration=40_000,
+            exclusive_time=40_000,
             tags={"foo": "qux"},
             measurements={
                 measurement: 40_000
@@ -716,6 +717,8 @@ def test_matching_tag_metrics(self):
                 query = {
                     "mri": mri,
                     "metricsQuery": ["foo:qux"],
+                    "metricsMin": 30_000,
+                    "metricsMax": 50_000,
                     "project": [project_1.id],
                     "field": ["id", "parent_span", "span.duration"],
                     "suggestedQuery": ["foo:qux"],