Skip to content

Commit 5f79cb2

Browse files
authored
feat(perf): Minor fixes to Requests view I (#69156)
- **Fix layout of onboarding panel** - **Provide correct span op** This makes the time spent descriptions more precise. - **`formatPercentage` `minimumValue` option** Just like `formatRate`! - **Support minimum values in metric readouts** - **Add bottom padding to detail panel**
1 parent 5f0e188 commit 5f79cb2

File tree

6 files changed

+25
-14
lines changed

6 files changed

+25
-14
lines changed

static/app/views/performance/http/domainTransactionsTable.tsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,12 @@ function renderBodyCell(
187187

188188
const renderer = getFieldRenderer(column.key, meta.fields, false);
189189

190-
return renderer(row, {
191-
location,
192-
organization,
193-
unit: meta.units?.[column.key],
194-
});
190+
return renderer(
191+
{...row, 'span.op': 'http.client'},
192+
{
193+
location,
194+
organization,
195+
unit: meta.units?.[column.key],
196+
}
197+
);
195198
}

static/app/views/performance/http/domainsTable.tsx

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,15 @@ function renderBodyCell(
188188

189189
const renderer = getFieldRenderer(column.key, meta.fields, false);
190190

191-
return renderer(row, {
192-
location,
193-
organization,
194-
unit: meta.units?.[column.key],
195-
});
191+
return renderer(
192+
{
193+
'span.op': 'http.client',
194+
...row,
195+
},
196+
{
197+
location,
198+
organization,
199+
unit: meta.units?.[column.key],
200+
}
201+
);
196202
}

static/app/views/performance/http/httpDomainSummaryPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ export function HTTPDomainSummaryPage() {
238238
unit={DurationUnit.MILLISECOND}
239239
tooltip={getTimeSpentExplanation(
240240
domainMetrics?.[0]?.['time_spent_percentage()'],
241-
'db'
241+
'http'
242242
)}
243243
isLoading={areDomainMetricsLoading}
244244
/>

static/app/views/performance/http/httpLandingPage.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,9 @@ export function HTTPLandingPage() {
159159
</ModuleLayout.Full>
160160

161161
{onboardingProject && (
162-
<Onboarding organization={organization} project={onboardingProject} />
162+
<ModuleLayout.Full>
163+
<Onboarding organization={organization} project={onboardingProject} />
164+
</ModuleLayout.Full>
163165
)}
164166

165167
{!onboardingProject && (

static/app/views/performance/http/httpSamplesPanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ export function HTTPSamplesPanel() {
349349
unit={DurationUnit.MILLISECOND}
350350
tooltip={getTimeSpentExplanation(
351351
domainTransactionMetrics?.[0]?.['time_spent_percentage()'],
352-
'db'
352+
'http.client'
353353
)}
354354
isLoading={areDomainTransactionMetricsFetching}
355355
/>

static/app/views/starfish/components/detailPanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,5 +147,5 @@ const CloseButtonWrapper = styled('div')`
147147
`;
148148

149149
const DetailWrapper = styled('div')`
150-
padding: 0 ${space(4)};
150+
padding: 0 ${space(4)} ${space(4)};
151151
`;

0 commit comments

Comments
 (0)