Remove File-based EventAttachment code

Already 17 months ago in #62318, I switched the `EventAttachment` code over from using the `file_id` and django `File`-models to storing things in filestore (the go service) directly via the `blob_path`.

As attachments have a 30 day TTL, it is high time to remove the backwards compatibility code.

Author: Swatinem

src/sentry/event_manager.py

@@ -2372,7 +2372,6 @@ def save_attachment(
         size=file.size,
         sha1=file.sha1,
         # storage:
-        file_id=file.file_id,
         blob_path=file.blob_path,
     )
 

src/sentry/models/eventattachment.py

@@ -8,7 +8,6 @@
 
 import zstandard
 from django.core.cache import cache
-from django.core.exceptions import ObjectDoesNotExist
 from django.db import models
 from django.utils import timezone
 
@@ -42,7 +41,6 @@ class PutfileResult:
     content_type: str
     size: int
     sha1: str
-    file_id: int | None = None
     blob_path: str | None = None
 
 
@@ -61,8 +59,7 @@ class EventAttachment(Model):
     """Attachment Metadata and Storage
 
     The actual attachment data can be saved in different backing stores:
-    - Using the :class:`File` model using the `file_id` field.
-      This stores attachments chunked and deduplicated.
+    - When the attachment is empty (0-size), `blob_path is None`.
     - When the `blob_path` field has a `:` prefix:
       It is saved inline in `blob_path` following the `:` prefix.
       This happens for "small" and ASCII-only (see `can_store_inline`) attachments.
@@ -88,8 +85,7 @@ class EventAttachment(Model):
 
     date_added = models.DateTimeField(default=timezone.now, db_index=True)
 
-    # the backing blob, either going through the `File` model,
-    # or directly to a backing blob store
+    # The `file_id` will be removed in a multi-part migration soon.
     file_id = BoundedBigIntegerField(null=True, db_index=True)
     blob_path = models.TextField(null=True)
 
@@ -114,51 +110,29 @@ def delete(self, *args: Any, **kwargs: Any) -> tuple[int, dict[str, int]]:
 
         if self.blob_path:
             if self.blob_path.startswith(":"):
-                return rv
+                pass  # nothing to do for inline-stored attachments
             elif self.blob_path.startswith("eventattachments/v1/"):
                 storage = get_storage()
+                storage.delete(self.blob_path)
             else:
                 raise NotImplementedError()
 
-            storage.delete(self.blob_path)
-            return rv
-
-        try:
-            from sentry.models.files.file import File
-
-            file = File.objects.get(id=self.file_id)
-        except ObjectDoesNotExist:
-            # It's possible that the File itself was deleted
-            # before we were deleted when the object is in memory
-            # This seems to be a case that happens during deletion
-            # code.
-            pass
-        else:
-            file.delete()
-
         return rv
 
     def getfile(self) -> IO[bytes]:
-        if self.size == 0:
+        if not self.blob_path:
             return BytesIO(b"")
 
-        if self.blob_path:
-            if self.blob_path.startswith(":"):
-                return BytesIO(self.blob_path[1:].encode())
-
-            elif self.blob_path.startswith("eventattachments/v1/"):
-                storage = get_storage()
-                compressed_blob = storage.open(self.blob_path)
-                dctx = zstandard.ZstdDecompressor()
-                return dctx.stream_reader(compressed_blob, read_across_frames=True)
+        if self.blob_path.startswith(":"):
+            return BytesIO(self.blob_path[1:].encode())
 
-            else:
-                raise NotImplementedError()
-
-        from sentry.models.files.file import File
+        elif self.blob_path.startswith("eventattachments/v1/"):
+            storage = get_storage()
+            compressed_blob = storage.open(self.blob_path)
+            dctx = zstandard.ZstdDecompressor()
+            return dctx.stream_reader(compressed_blob, read_across_frames=True)
 
-        file = File.objects.get(id=self.file_id)
-        return file.getfile()
+        raise NotImplementedError()
 
     @classmethod
     def putfile(cls, project_id: int, attachment: CachedAttachment) -> PutfileResult:
@@ -171,7 +145,6 @@ def putfile(cls, project_id: int, attachment: CachedAttachment) -> PutfileResult
             return PutfileResult(content_type=content_type, size=0, sha1=sha1().hexdigest())
 
         blob = BytesIO(data)
-
         size, checksum = get_size_and_checksum(blob)
 
         if can_store_inline(data):

tests/sentry/api/endpoints/test_event_attachment_details.py

@@ -35,10 +35,7 @@ def create_attachment(self, content: bytes | None = None, group_id: int | None =
         attachment = CachedAttachment(
             name="hello.png", content_type="image/png; foo=bar", data=data
         )
-        file = EventAttachment.putfile(
-            self.project.id,
-            attachment,
-        )
+        file = EventAttachment.putfile(self.project.id, attachment)
 
         self.attachment = EventAttachment.objects.create(
             event_id=self.event.event_id,
@@ -50,7 +47,6 @@ def create_attachment(self, content: bytes | None = None, group_id: int | None =
             size=file.size,
             sha1=file.sha1,
             # storage:
-            file_id=file.file_id,
             blob_path=file.blob_path,
         )