fix(trace-explorer): Do not prematurely narrow date range

If we prematurely narrow the date range, there are some cases where a span isn't
found in the results. So remove this attempted optimization.

Author: Zylphrex

src/sentry/api/endpoints/organization_traces.py

@@ -342,8 +342,6 @@ def get_traces_matching_metric_conditions(
         if not trace_ids or min_timestamp > max_timestamp:
             return min_timestamp, max_timestamp, [], []
 
-        self.refine_params(min_timestamp, max_timestamp)
-
         if self.user_queries:
             # If there are user queries, further refine the trace ids by applying them
             # leaving us with only traces where the metric exists and matches the user
@@ -356,16 +354,19 @@ def get_traces_matching_metric_conditions(
                 return min_timestamp, max_timestamp, [], []
         else:
             # No user queries so take the first N trace ids as our list
+            min_timestamp = snuba_params.end
+            max_timestamp = snuba_params.start
+            assert min_timestamp is not None
+            assert max_timestamp is not None
+
             trace_ids = trace_ids[: self.limit]
             timestamps = timestamps[: self.limit]
             for timestamp in timestamps:
                 if timestamp < min_timestamp:
                     min_timestamp = timestamp
-                if timestamp < max_timestamp:
+                if timestamp > max_timestamp:
                     max_timestamp = timestamp
 
-        self.refine_params(min_timestamp, max_timestamp)
-
         span_keys = executor.get_matching_spans_from_traces(
             trace_ids,
             self.max_spans_per_trace,

src/sentry/sentry_metrics/querying/samples_list.py

@@ -258,7 +258,7 @@ def get_matching_spans_from_traces(
             # This also means we cannot order by any columns or paginate.
             orderby=None,
             limit=len(trace_ids) * max_spans_per_trace,
-            limitby=("trace", 1),
+            limitby=("trace", max_spans_per_trace),
         )
 
         trace_id_condition = Condition(Column("trace_id"), Op.IN, trace_ids)
@@ -609,7 +609,7 @@ def get_matching_spans_from_traces(
             # This also means we cannot order by any columns or paginate.
             orderby=None,
             limit=len(trace_ids) * max_spans_per_trace,
-            limitby=("trace", 1),
+            limitby=("trace", max_spans_per_trace),
         )
 
         trace_id_condition = Condition(Column("trace_id"), Op.IN, trace_ids)
@@ -943,7 +943,7 @@ def get_matching_spans_from_traces(
             # This also means we cannot order by any columns or paginate.
             orderby=None,
             limit=len(trace_ids) * max_spans_per_trace,
-            limitby=("trace", 1),
+            limitby=("trace", max_spans_per_trace),
         )
 
         trace_id_condition = Condition(Column("trace_id"), Op.IN, trace_ids)