|
1 | | -from unittest import mock |
2 | | - |
3 | 1 | import pytest |
4 | 2 |
|
5 | | -from sentry.grouping.parameterization import ( |
6 | | - ParameterizationRegexExperiment, |
7 | | - Parameterizer, |
8 | | - UniqueIdExperiment, |
9 | | -) |
| 3 | +from sentry.grouping.parameterization import Parameterizer, UniqueIdExperiment |
10 | 4 | from sentry.grouping.strategies.message import REGEX_PATTERN_KEYS |
11 | 5 |
|
12 | 6 |
|
@@ -227,43 +221,6 @@ def test_parameterize_experiment(name, input, expected, parameterizer): |
227 | 221 | assert experiments[0] == UniqueIdExperiment |
228 | 222 |
|
229 | 223 |
|
230 | | -def test_parameterize_regex_experiment(): |
231 | | - """ |
232 | | - We don't have any of these yet, but we need to test that they work |
233 | | - """ |
234 | | - FooExperiment = ParameterizationRegexExperiment(name="foo", raw_pattern=r"f[oO]{2}") |
235 | | - |
236 | | - parameterizer = Parameterizer( |
237 | | - regex_pattern_keys=(), |
238 | | - experiments=(FooExperiment,), |
239 | | - ) |
240 | | - input_str = "blah foobarbaz fooooo" |
241 | | - normalized = parameterizer.parameterize_all(input_str) |
242 | | - assert normalized == "blah <foo>barbaz <foo>ooo" |
243 | | - assert len(parameterizer.get_successful_experiments()) == 1 |
244 | | - assert parameterizer.get_successful_experiments()[0] == FooExperiment |
245 | | - |
246 | | - |
247 | | -def test_parameterize_regex_experiment_cached_compiled(): |
248 | | - |
249 | | - with mock.patch.object( |
250 | | - ParameterizationRegexExperiment, |
251 | | - "pattern", |
252 | | - new_callable=mock.PropertyMock, |
253 | | - return_value=r"(?P<foo>f[oO]{2})", |
254 | | - ) as mocked_pattern: |
255 | | - FooExperiment = ParameterizationRegexExperiment(name="foo", raw_pattern=r"f[oO]{2}") |
256 | | - parameterizer = Parameterizer( |
257 | | - regex_pattern_keys=(), |
258 | | - experiments=(FooExperiment,), |
259 | | - ) |
260 | | - input_str = "blah foobarbaz fooooo" |
261 | | - _ = parameterizer.parameterize_all(input_str) |
262 | | - _ = parameterizer.parameterize_all(input_str) |
263 | | - |
264 | | - mocked_pattern.assert_called_once() |
265 | | - |
266 | | - |
267 | 224 | # These are test cases that we should fix |
268 | 225 | @pytest.mark.xfail() |
269 | 226 | @pytest.mark.parametrize( |
|
0 commit comments