Skip to content

Commit b9641cf

Browse files
lzhao-sentrypriscilawebdev
authored andcommitted
ref(cell-actions): better interactions for ID and clearer menu indication (#97888)
### Changes See for more context: https://sentry.slack.com/archives/C05FUFGPGFM/p1755198491001089 * Span ID has no cell actions in Explore table * URLs with cell actions are no longer styled with blue/purple text colour to indicate they open a menu * Swapped the text bold to a text shadow to avoid shifting columns ### Video https://github.com/user-attachments/assets/79a4c0b6-55e2-4c5e-9b78-81b7e51f9af1
1 parent 62ba09c commit b9641cf

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

static/app/views/discover/table/cellAction.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -299,8 +299,6 @@ function makeCellActions({
299299
*/
300300
function getInternalLinkActionLabel(field: string): string {
301301
switch (field) {
302-
case FieldKey.ID:
303-
return t('Open view');
304302
case FieldKey.TRACE:
305303
return t('Open trace');
306304
case FieldKey.PROJECT:
@@ -478,8 +476,12 @@ const ActionMenuTrigger = styled(Button)`
478476
`;
479477

480478
const ActionMenuTriggerV2 = styled('div')`
479+
a,
480+
span {
481+
color: ${p => p.theme.textColor};
482+
}
481483
:hover {
482484
cursor: pointer;
483-
font-weight: ${p => p.theme.fontWeight.bold};
485+
text-shadow: 0.5px 0px;
484486
}
485487
`;

static/app/views/explore/tables/fieldRenderer.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,10 @@ function BaseExploreFieldRenderer({
162162
});
163163

164164
rendered = <Link to={target}>{rendered}</Link>;
165+
166+
if (organization.features.includes('discover-cell-actions-v2') && field === 'id') {
167+
return rendered;
168+
}
165169
}
166170

167171
if (field === 'profile.id') {

0 commit comments

Comments
 (0)