log out issue

Author: nhsiehgit

src/sentry/api/serializers/models/alert_rule.py

@@ -352,7 +352,19 @@ def get_attrs(
                 # This is a metric alert rule
                 serialized_alert_rule = serialized_alert_rule_map_by_id[item_id]
                 if "latestIncident" in self.expand:
-                    serialized_alert_rule["latestIncident"] = incident_map.get(item.incident_id)  # type: ignore[attr-defined]
+                    # Eg. we _have_ an incident
+                    try:
+                        serialized_alert_rule["latestIncident"] = incident_map.get(item.incident_id)
+                    except AttributeError as e:
+                        logger.exception(
+                            "incident serialization error",
+                            extra={
+                                "exception": e,
+                                "alert_rule_id": item_id,
+                                "is_metric_alert": isinstance(item, AlertRule),
+                                "is_issue_alert": isinstance(item, Rule),
+                            },
+                        )
                 results[item] = serialized_alert_rule
             elif item_id in serialized_issue_rule_map_by_id:
                 # This is an issue alert rule