feat(usage): Rename metrics to metricSecond

Currently this is only used in the stats_v2 api but needs to line up with the metricSecond we're adding for billing.

Should not be merged before #70442

Author: scttcper

static/app/constants/index.tsx

@@ -318,9 +318,9 @@ export const DATA_CATEGORY_INFO = {
     titleName: t('Cron Monitors'),
     uid: 13,
   },
-  [DataCategoryExact.METRICS]: {
-    name: DataCategoryExact.METRICS,
-    apiName: 'metrics',
+  [DataCategoryExact.METRIC_SECOND]: {
+    name: DataCategoryExact.METRIC_SECOND,
+    apiName: 'metricSecond',
     plural: 'metrics',
     displayName: 'metrics',
     titleName: t('Metrics'),

static/app/types/core.tsx

@@ -80,6 +80,7 @@ export enum DataCategory {
   PROFILES = 'profiles',
   REPLAYS = 'replays',
   MONITOR_SEATS = 'monitorSeats',
+  METRIC_SECOND = 'metricSecond',
 }
 
 /**
@@ -97,7 +98,7 @@ export enum DataCategoryExact {
   TRANSACTION_INDEXED = 'transaction_indexed',
   MONITOR = 'monitor',
   MONITOR_SEAT = 'monitorSeat',
-  METRICS = 'metrics',
+  METRIC_SECOND = 'metricSecond',
 }
 
 export interface DataCategoryInfo {

static/app/views/organizationStats/index.tsx

@@ -263,7 +263,7 @@ export class OrganizationStats extends Component<OrganizationStatsProps> {
       if (opt.value === DATA_CATEGORY_INFO.replay.plural) {
         return organization.features.includes('session-replay');
       }
-      if (opt.value === DATA_CATEGORY_INFO.metrics.plural) {
+      if (opt.value === DATA_CATEGORY_INFO.metricSecond.plural) {
         return hasMetricStats(organization);
       }
       return true;
@@ -321,7 +321,7 @@ export class OrganizationStats extends Component<OrganizationStatsProps> {
       if (opt.value === DATA_CATEGORY_INFO.replay.plural) {
         return organization.features.includes('session-replay');
       }
-      if (opt.value === DATA_CATEGORY_INFO.metrics.plural) {
+      if (opt.value === DATA_CATEGORY_INFO.metricSecond.plural) {
         return hasMetricStats(organization);
       }
       return true;

static/app/views/organizationStats/usageChart/index.tsx

@@ -89,8 +89,8 @@ export const CHART_OPTIONS_DATACATEGORY: CategoryOption[] = [
     yAxisMinInterval: 100,
   },
   {
-    label: DATA_CATEGORY_INFO.metrics.titleName,
-    value: DATA_CATEGORY_INFO.metrics.plural,
+    label: DATA_CATEGORY_INFO.metricSecond.titleName,
+    value: DATA_CATEGORY_INFO.metricSecond.plural,
     disabled: false,
     yAxisMinInterval: 100,
   },
@@ -361,7 +361,7 @@ function UsageChartBody({
 
   const filteredOptions = useMemo(() => {
     return categoryOptions.filter(option => {
-      if (option.value !== DATA_CATEGORY_INFO.metrics.plural) {
+      if (option.value !== DATA_CATEGORY_INFO.metricSecond.plural) {
         return true;
       }
       return (

static/app/views/organizationStats/usageStatsOrg.tsx

@@ -136,7 +136,7 @@ class UsageStatsOrganization<
           {
             query: {
               ...this.endpointQuery,
-              category: DATA_CATEGORY_INFO.metrics.apiName,
+              category: DATA_CATEGORY_INFO.metricSecond.apiName,
               groupBy: ['outcome'],
             },
           },
@@ -159,7 +159,7 @@ class UsageStatsOrganization<
         ...group,
         by: {
           ...group.by,
-          category: DATA_CATEGORY_INFO.metrics.apiName,
+          category: DATA_CATEGORY_INFO.metricSecond.apiName,
         },
       };
     });
@@ -345,7 +345,7 @@ class UsageStatsOrganization<
       filtered: {
         title: tct('Filtered [dataCategory]', {dataCategory: dataCategoryName}),
         help:
-          dataCategory === DATA_CATEGORY_INFO.metrics.plural
+          dataCategory === DATA_CATEGORY_INFO.metricSecond.plural
             ? tct(
                 'Filtered metrics were blocked due to your disabled metrics [settings: settings]',
                 {

static/app/views/organizationStats/usageStatsPerMin.tsx

@@ -78,7 +78,7 @@ function UsageStatsPerMin({dataCategory, organization, projectIds}: Props) {
   };
 
   // Metrics stats ingestion is delayed, so we can't show this for metrics right now
-  if (dataCategory === DATA_CATEGORY_INFO.metrics.plural) {
+  if (dataCategory === DATA_CATEGORY_INFO.metricSecond.plural) {
     return null;
   }