Skip to content

Commit d82a1bb

Browse files
committed
ref(related_issues): Make the code a bit more clear
1 parent b030c4c commit d82a1bb

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

static/app/views/issueDetails/groupEventCarousel.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -426,6 +426,7 @@ export function GroupEventCarousel({event, group, projectSlug}: GroupEventCarous
426426
)}
427427
</EventIdAndTimeContainer>
428428
</EventHeading>
429+
{/* Once trace-related issues are GA, we will remove this */}
429430
{issueTypeConfig.traceTimeline && !isRelatedIssuesEnabled ? (
430431
<TraceLink event={event} />
431432
) : null}

static/app/views/issueDetails/groupEventHeader.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,23 @@ function GroupEventHeader({event, group, project}: GroupEventHeaderProps) {
2626
'related-issues-issue-details-page'
2727
);
2828
// This is also called within the TraceTimeline component but caching will save a second call
29-
const {isError, isLoading, oneOtherIssueEvent} = useTraceTimelineEvents({
29+
const {oneOtherIssueEvent} = useTraceTimelineEvents({
3030
event,
3131
});
32-
const readyToShow = !isLoading && !isError;
3332

3433
return (
3534
<StyledDataSection>
3635
<GroupEventCarousel group={group} event={event} projectSlug={project.slug} />
37-
{isRelatedIssuesEnabled && readyToShow && oneOtherIssueEvent === undefined && (
38-
<TraceLink event={event} />
39-
)}
4036
{isRelatedIssuesEnabled && oneOtherIssueEvent && (
4137
<StyledTraceLink>
4238
One other issue appears in the same trace.
43-
{readyToShow && <TraceLink event={event} />}
39+
<TraceLink event={event} />
4440
</StyledTraceLink>
4541
)}
42+
{/* This will be the default when we have GAed related issues */}
43+
{isRelatedIssuesEnabled && oneOtherIssueEvent === undefined && (
44+
<TraceLink event={event} />
45+
)}
4646
{issueTypeConfig.traceTimeline && <TraceTimeline event={event} />}
4747
<StyledGlobalAppStoreConnectUpdateAlert
4848
project={project}

0 commit comments

Comments
 (0)