Fix tests and missed refactor of function name

Author: armenzg

tests/sentry/issues/auto_source_code_config/test_process_event.py

@@ -71,7 +71,7 @@ def create_event(self, frames: Sequence[Mapping[str, str | bool]], platform: str
         # XXX: In the future fix store_event to return the correct type
         return cast(GroupEvent, self.store_event(data=test_data, project_id=self.project.id))
 
-    def _process_and_assert_code_mapping(
+    def _process_and_assert_configuration_changes(
         self,
         *,  # Force keyword arguments
         repo_trees: Mapping[str, Sequence[str]],
@@ -127,7 +127,7 @@ def _process_and_assert_code_mapping(
             # Returning this is useful to inspect hash changes
             return event
 
-    def _process_and_assert_no_code_mapping(
+    def _process_and_assert_no_configuration_changes(
         self,
         *,  # Force keyword arguments
         repo_trees: Mapping[str, Sequence[str]],
@@ -212,7 +212,9 @@ class TestGenericBehaviour(BaseDeriveCodeMappings):
 
     def test_skips_not_supported_platforms(self) -> None:
         with patch(f"{CODE_ROOT}.utils.get_platform_config", return_value={}):
-            self._process_and_assert_no_code_mapping(repo_trees={}, frames=[{}], platform="other")
+            self._process_and_assert_no_configuration_changes(
+                repo_trees={}, frames=[{}], platform="other"
+            )
 
     def test_handle_existing_code_mapping(self) -> None:
         with assume_test_silo_mode_of(OrganizationIntegration):
@@ -252,7 +254,7 @@ def test_dry_run_platform(self) -> None:
             patch(f"{CODE_ROOT}.utils.PlatformConfig.is_dry_run_platform", return_value=True),
         ):
             # No code mapping will be stored, however, we get what would have been created
-            code_mappings, _ = self._process_and_assert_no_code_mapping(
+            code_mappings, _ = self._process_and_assert_no_configuration_changes(
                 repo_trees={REPO1: [file_in_repo]},
                 frames=[self.frame(frame_filename, True)],
                 platform=platform,
@@ -272,14 +274,14 @@ def test_extension_is_not_included(self) -> None:
             patch(f"{REPO_TREES_CODE}.get_supported_extensions", return_value=[]),
         ):
             # No extensions are supported, thus, we can't generate a code mapping
-            self._process_and_assert_no_code_mapping(
+            self._process_and_assert_no_configuration_changes(
                 repo_trees={REPO1: [file_in_repo]},
                 frames=[self.frame(frame_filename, True)],
                 platform=platform,
             )
 
             with patch(f"{REPO_TREES_CODE}.get_supported_extensions", return_value=["tbd"]):
-                self._process_and_assert_code_mapping(
+                self._process_and_assert_configuration_changes(
                     repo_trees={REPO1: [file_in_repo]},
                     frames=[self.frame(frame_filename, True)],
                     platform=platform,
@@ -298,7 +300,7 @@ def test_multiple_calls(self) -> None:
             patch(f"{CODE_ROOT}.utils.get_platform_config", return_value={}),
             patch(f"{CODE_ROOT}.utils.PlatformConfig.is_supported", return_value=True),
         ):
-            self._process_and_assert_code_mapping(
+            self._process_and_assert_configuration_changes(
                 repo_trees=repo_trees,
                 frames=[self.frame("foo/bar.py", True)],
                 platform=platform,
@@ -308,7 +310,7 @@ def test_multiple_calls(self) -> None:
                 expected_num_code_mappings=1,
             )
             # Processing the same stacktrace again should not create anything new
-            self._process_and_assert_code_mapping(
+            self._process_and_assert_configuration_changes(
                 repo_trees=repo_trees,
                 frames=[self.frame("foo/bar.py", True)],
                 platform=platform,
@@ -318,7 +320,7 @@ def test_multiple_calls(self) -> None:
                 expected_num_code_mappings=1,
             )
             # New code mapping in the same repository
-            self._process_and_assert_code_mapping(
+            self._process_and_assert_configuration_changes(
                 repo_trees=repo_trees,
                 frames=[self.frame("app/main.py", True)],
                 platform=platform,
@@ -328,7 +330,7 @@ def test_multiple_calls(self) -> None:
                 expected_num_code_mappings=2,  # New code mapping
             )
             # New code mapping in a different repository
-            self._process_and_assert_code_mapping(
+            self._process_and_assert_configuration_changes(
                 repo_trees=repo_trees,
                 frames=[self.frame("baz/qux.py", True)],
                 platform=platform,
@@ -356,7 +358,7 @@ def test_backslash_filename_simple(self) -> None:
         # The lack of a \ after the drive letter in the third frame signals that
         # this is a relative path. This may be unlikely to occur in practice,
         # but worth testing nonetheless.
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/mouse.py"]},
             frames=[self.frame("\\sentry\\mouse.py", True)],
             platform=self.platform,
@@ -365,7 +367,7 @@ def test_backslash_filename_simple(self) -> None:
         )
 
     def test_backslash_drive_letter_filename_simple(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/tasks.py"]},
             frames=[self.frame("C:sentry\\tasks.py", True)],
             platform=self.platform,
@@ -374,7 +376,7 @@ def test_backslash_drive_letter_filename_simple(self) -> None:
         )
 
     def test_backslash_drive_letter_filename_monoRepoAndBranch(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/tasks.py"]},
             frames=[self.frame("C:sentry\\tasks.py", True)],
             platform=self.platform,
@@ -383,7 +385,7 @@ def test_backslash_drive_letter_filename_monoRepoAndBranch(self) -> None:
         )
 
     def test_backslash_drive_letter_filename_abs_path(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/models/release.py"]},
             frames=[self.frame("D:\\Users\\code\\sentry\\models\\release.py", True)],
             platform=self.platform,
@@ -397,7 +399,7 @@ class TestJavascriptDeriveCodeMappings(LanguageSpecificDeriveCodeMappings):
 
     def test_auto_source_code_config_starts_with_period_slash(self) -> None:
         # ./app/utils/handle.tsx -> app/utils/handle.tsx -> static/app/utils/handle.tsx
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["static/app/utils/handle.tsx"]},
             frames=[self.frame("./app/utils/handle.tsx", True)],
             platform=self.platform,
@@ -406,7 +408,7 @@ def test_auto_source_code_config_starts_with_period_slash(self) -> None:
         )
 
     def test_auto_source_code_config_starts_with_period_slash_no_containing_directory(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["app/utils/handle.tsx"]},
             frames=[self.frame("./app/utils/handle.tsx", True)],
             platform=self.platform,
@@ -415,7 +417,7 @@ def test_auto_source_code_config_starts_with_period_slash_no_containing_director
         )
 
     def test_auto_source_code_config_one_to_one_match(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["some/path/Test.tsx"]},
             frames=[self.frame("some/path/Test.tsx", True)],
             platform=self.platform,
@@ -428,7 +430,7 @@ class TestRubyDeriveCodeMappings(LanguageSpecificDeriveCodeMappings):
     platform = "ruby"
 
     def test_auto_source_code_config_rb(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["some/path/test.rb"]},
             frames=[self.frame("some/path/test.rb", True)],
             platform=self.platform,
@@ -437,7 +439,7 @@ def test_auto_source_code_config_rb(self) -> None:
         )
 
     def test_auto_source_code_config_rake(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["lib/tasks/crontask.rake"]},
             frames=[self.frame("lib/tasks/crontask.rake", True)],
             platform=self.platform,
@@ -451,7 +453,7 @@ class TestNodeDeriveCodeMappings(LanguageSpecificDeriveCodeMappings):
 
     def test_auto_source_code_config_starts_with_app(self) -> None:
         # It can handle app:// urls
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["utils/errors.js"]},
             frames=[self.frame("app:///utils/errors.js", True)],
             platform=self.platform,
@@ -460,7 +462,7 @@ def test_auto_source_code_config_starts_with_app(self) -> None:
         )
 
     def test_auto_source_code_config_starts_with_app_complex(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/utils/errors.js"]},
             frames=[self.frame("app:///utils/errors.js", True)],
             platform=self.platform,
@@ -470,7 +472,7 @@ def test_auto_source_code_config_starts_with_app_complex(self) -> None:
 
     def test_auto_source_code_config_starts_with_multiple_dot_dot_slash(self) -> None:
         # It can handle relative paths
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["packages/api/src/response.ts"]},
             frames=[self.frame("../../packages/api/src/response.ts", True)],
             platform=self.platform,
@@ -480,7 +482,7 @@ def test_auto_source_code_config_starts_with_multiple_dot_dot_slash(self) -> Non
 
     def test_auto_source_code_config_starts_with_app_dot_dot_slash(self) -> None:
         # It can handle app:// urls with dot dot slashes
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["services/event/index.js"]},
             frames=[self.frame("app:///../services/event/index.js", True)],
             platform=self.platform,
@@ -493,7 +495,7 @@ class TestGoDeriveCodeMappings(LanguageSpecificDeriveCodeMappings):
     platform = "go"
 
     def test_auto_source_code_config_go_abs_filename(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/capybara.go"]},
             frames=[self.frame("/Users/JohnDoe/code/sentry/capybara.go", True)],
             platform=self.platform,
@@ -502,7 +504,7 @@ def test_auto_source_code_config_go_abs_filename(self) -> None:
         )
 
     def test_auto_source_code_config_go_long_abs_filename(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/kangaroo.go"]},
             frames=[self.frame("/Users/JohnDoe/code/sentry/kangaroo.go", True)],
             platform=self.platform,
@@ -511,7 +513,7 @@ def test_auto_source_code_config_go_long_abs_filename(self) -> None:
         )
 
     def test_auto_source_code_config_similar_but_incorrect_file(self) -> None:
-        self._process_and_assert_no_code_mapping(
+        self._process_and_assert_no_configuration_changes(
             repo_trees={REPO1: ["not-sentry/main.go"]},
             frames=[self.frame("Users/JohnDoe/src/sentry/main.go", True)],
             platform=self.platform,
@@ -527,7 +529,7 @@ class TestPhpDeriveCodeMappings(LanguageSpecificDeriveCodeMappings):
     ]
 
     def test_auto_source_code_config_basic_php(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/p/kanga.php"]},
             frames=[self.frame("/sentry/p/kanga.php", True)],
             platform=self.platform,
@@ -536,7 +538,7 @@ def test_auto_source_code_config_basic_php(self) -> None:
         )
 
     def test_auto_source_code_config_different_roots_php(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["src/sentry/p/kanga.php"]},
             frames=[self.frame("/sentry/p/kanga.php", True)],
             platform=self.platform,
@@ -549,7 +551,7 @@ class TestCSharpDeriveCodeMappings(LanguageSpecificDeriveCodeMappings):
     platform = "csharp"
 
     def test_auto_source_code_config_csharp_trivial(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/p/kanga.cs"]},
             frames=[self.frame("/sentry/p/kanga.cs", True)],
             platform=self.platform,
@@ -558,7 +560,7 @@ def test_auto_source_code_config_csharp_trivial(self) -> None:
         )
 
     def test_auto_source_code_config_different_roots_csharp(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["src/sentry/p/kanga.cs"]},
             frames=[self.frame("/sentry/p/kanga.cs", True)],
             platform=self.platform,
@@ -567,7 +569,7 @@ def test_auto_source_code_config_different_roots_csharp(self) -> None:
         )
 
     def test_auto_source_code_config_non_in_app_frame(self) -> None:
-        self._process_and_assert_no_code_mapping(
+        self._process_and_assert_no_configuration_changes(
             repo_trees={REPO1: ["sentry/src/functions.cs"]},
             frames=[self.frame("/sentry/p/vendor/sentry/src/functions.cs", False)],
             platform=self.platform,
@@ -578,7 +580,7 @@ class TestPythonDeriveCodeMappings(LanguageSpecificDeriveCodeMappings):
     platform = "python"
 
     def test_auto_source_code_config_stack_and_source_root_do_not_match(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["src/sentry/foo/bar.py"]},
             frames=[self.frame("sentry/foo/bar.py", True)],
             platform=self.platform,
@@ -587,7 +589,7 @@ def test_auto_source_code_config_stack_and_source_root_do_not_match(self) -> Non
         )
 
     def test_auto_source_code_config_no_normalization(self) -> None:
-        self._process_and_assert_code_mapping(
+        self._process_and_assert_configuration_changes(
             repo_trees={REPO1: ["sentry/foo/bar.py"]},
             frames=[self.frame("sentry/foo/bar.py", True)],
             platform=self.platform,
@@ -601,7 +603,7 @@ class TestJavaDeriveCodeMappings(LanguageSpecificDeriveCodeMappings):
 
     def test_very_short_module_name(self) -> None:
         # No code mapping will be stored, however, we get what would have been created
-        code_mappings, in_app_stack_trace_rules = self._process_and_assert_no_code_mapping(
+        code_mappings, _ = self._process_and_assert_no_configuration_changes(
             repo_trees={REPO1: ["src/a/SomeShortPackageNameClass.java"]},
             frames=[
                 {
@@ -614,11 +616,10 @@ def test_very_short_module_name(self) -> None:
         assert len(code_mappings) == 1
         assert code_mappings[0].stacktrace_root == "a/"
         assert code_mappings[0].source_path == "src/a/"
-        assert in_app_stack_trace_rules == ["stack.module:a.** +app"]
 
     def test_handles_dollar_sign_in_module(self) -> None:
         # No code mapping will be stored, however, we get what would have been created
-        code_mappings, in_app_stack_trace_rules = self._process_and_assert_no_code_mapping(
+        code_mappings, _ = self._process_and_assert_no_configuration_changes(
             repo_trees={REPO1: ["src/com/example/foo/Bar.kt"]},
             frames=[{"module": "com.example.foo.Bar$InnerClass", "abs_path": "Bar.kt"}],
             platform=self.platform,