Skip to content

Commit fe08250

Browse files
ref(feedback): num_feedbacks_used -> numFeedbacksUsed in summary endpoint (#93672)
1 parent 44dead5 commit fe08250

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/sentry/api/endpoints/organization_feedback_summary.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def get(self, request: Request, organization: Organization) -> Response:
7777

7878
if groups.count() < MIN_FEEDBACKS_TO_SUMMARIZE:
7979
logger.error("Too few feedbacks to summarize")
80-
return Response({"summary": None, "success": False, "num_feedbacks_used": 0})
80+
return Response({"summary": None, "success": False, "numFeedbacksUsed": 0})
8181

8282
# Also cap the number of characters that we send to the LLM
8383
group_feedbacks = []
@@ -100,5 +100,5 @@ def get(self, request: Request, organization: Organization) -> Response:
100100
return Response({"detail": "Error generating summary"}, status=500)
101101

102102
return Response(
103-
{"summary": summary, "success": True, "num_feedbacks_used": len(group_feedbacks)}
103+
{"summary": summary, "success": True, "numFeedbacksUsed": len(group_feedbacks)}
104104
)

tests/sentry/api/endpoints/test_organization_feedback_summary.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def test_get_feedback_summary_basic(self, mock_generate_summary):
9191

9292
assert response.data["success"] is True
9393
assert response.data["summary"] == "Test summary of feedback"
94-
assert response.data["num_feedbacks_used"] == 15
94+
assert response.data["numFeedbacksUsed"] == 15
9595

9696
@django_db_all
9797
@patch(
@@ -122,7 +122,7 @@ def test_get_feedback_summary_with_date_filter(self, mock_generate_summary):
122122

123123
assert response.data["success"] is True
124124
assert response.data["summary"] == "Test summary of feedback"
125-
assert response.data["num_feedbacks_used"] == 12
125+
assert response.data["numFeedbacksUsed"] == 12
126126

127127
@django_db_all
128128
@patch(
@@ -151,7 +151,7 @@ def test_get_feedback_summary_with_project_filter(self, mock_generate_summary):
151151

152152
assert response.data["success"] is True
153153
assert response.data["summary"] == "Test summary of feedback"
154-
assert response.data["num_feedbacks_used"] == 10
154+
assert response.data["numFeedbacksUsed"] == 10
155155

156156
@django_db_all
157157
@patch(
@@ -180,7 +180,7 @@ def test_get_feedback_summary_with_many_project_filter_as_list(self, mock_genera
180180

181181
assert response.data["success"] is True
182182
assert response.data["summary"] == "Test summary of feedback"
183-
assert response.data["num_feedbacks_used"] == 22
183+
assert response.data["numFeedbacksUsed"] == 22
184184

185185
@django_db_all
186186
@patch(
@@ -208,7 +208,7 @@ def test_get_feedback_summary_with_many_project_filter_separate(self, mock_gener
208208
assert response.status_code == 200
209209
assert response.data["success"] is True
210210
assert response.data["summary"] == "Test summary of feedback"
211-
assert response.data["num_feedbacks_used"] == 22
211+
assert response.data["numFeedbacksUsed"] == 22
212212

213213
@django_db_all
214214
@patch(
@@ -259,4 +259,4 @@ def test_get_feedback_summary_character_limit(self, mock_generate_summary):
259259

260260
assert response.data["success"] is True
261261
assert response.data["summary"] == "Test summary of feedback"
262-
assert response.data["num_feedbacks_used"] == 12
262+
assert response.data["numFeedbacksUsed"] == 12

0 commit comments

Comments
 (0)