Skip to content

Conversation

@gggritso
Copy link
Member

@gggritso gggritso commented Jun 4, 2024

Re-creation of #71821 which I had to fast-revert

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 4, 2024
@codecov
Copy link

codecov bot commented Jun 4, 2024

Bundle Report

Changes will increase total bundle size by 715 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.92MB 715 bytes ⬆️

@codecov
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.94%. Comparing base (5d78a21) to head (1780052).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72001      +/-   ##
==========================================
- Coverage   77.94%   77.94%   -0.01%     
==========================================
  Files        6572     6572              
  Lines      292601   292601              
  Branches    50520    50524       +4     
==========================================
- Hits       228058   228056       -2     
- Misses      58292    58294       +2     
  Partials     6251     6251              
Files Coverage Δ
...ents/events/interfaces/spans/spanSummaryButton.tsx 58.82% <ø> (ø)
static/app/components/sidebar/index.tsx 80.71% <100.00%> (ø)
.../app/views/performance/browser/resources/index.tsx 100.00% <ø> (ø)
...ce/browser/resources/resourceSummaryPage/index.tsx 0.00% <ø> (ø)
...rformance/browser/resources/resourceView/index.tsx 65.90% <100.00%> (ø)
...ews/performance/browser/webVitals/pageOverview.tsx 68.08% <ø> (ø)
...ormance/browser/webVitals/webVitalsLandingPage.tsx 82.75% <ø> (ø)
...c/app/views/performance/cache/cacheLandingPage.tsx 0.00% <ø> (ø)
...views/performance/database/databaseLandingPage.tsx 76.31% <ø> (ø)
...s/performance/database/databaseSpanSummaryPage.tsx 92.59% <ø> (ø)
... and 21 more

... and 1 file with indirect coverage changes

@gggritso gggritso marked this pull request as ready for review June 4, 2024 14:13
@gggritso gggritso requested review from a team June 4, 2024 14:13
@gggritso gggritso merged commit 4e1fb8e into master Jun 4, 2024
@gggritso gggritso deleted the feat/insights/granular-feature-flags branch June 4, 2024 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants