-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(insights): Granular frontend feature flags II #72001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to see aggregate spans you need _some_ amount of span metrics. So, `insights-initial-modules` is a good fit here.
Bundle ReportChanges will increase total bundle size by 715 bytes ⬆️
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72001 +/- ##
==========================================
- Coverage 77.94% 77.94% -0.01%
==========================================
Files 6572 6572
Lines 292601 292601
Branches 50520 50524 +4
==========================================
- Hits 228058 228056 -2
- Misses 58292 58294 +2
Partials 6251 6251
|
DominikB2014
approved these changes
Jun 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creation of #71821 which I had to fast-revert