Skip to content

ref: fix missing Generic in spans.consumer strategy #74683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

ref: fix missing Generic in spans.consumer strategy #74683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/sentry/spans/consumers/process/strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
from typing import Any, TypeVar
from typing import Any, Generic, TypeVar

from arroyo.processing.strategies.abstract import ProcessingStrategy
from arroyo.processing.strategies.commit import CommitOffsets
from arroyo.types import Commit, FilteredPayload, Message
from arroyo.types import Commit, Message

TPayload = TypeVar("TPayload")


class CommitSpanOffsets(CommitOffsets):
class CommitSpanOffsets(CommitOffsets, Generic[TPayload]):
"""
Inherits from CommitOffsets so we can add a next step. We'd like to commit offsets for
processed spans before carrying on the work to build segments and produce them since
the processing messages and producing segments are two distinct operations. Span messages
should be committed once they are processed and put into redis.
"""

def __init__(
self, commit: Commit, next_step: ProcessingStrategy[FilteredPayload | TPayload]
) -> None:
def __init__(self, commit: Commit, next_step: ProcessingStrategy[TPayload]) -> None:
super().__init__(commit=commit)
self.__next_step = next_step

Expand Down