Skip to content

fix(insights): Cache page alert re-rendering #74737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix(insights): Cache page alert re-rendering #74737

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
304bc6d
fix(insights): Cache page alert re-rendering
narsaynorath Jul 23, 2024
0ac8262
Use useCallback
narsaynorath Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions static/app/utils/performance/contexts/pageAlert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type React from 'react';
import {createContext, Fragment, useContext, useState} from 'react';
import {createContext, Fragment, useCallback, useContext, useState} from 'react';
import type {Theme} from '@emotion/react';

import {Alert} from 'sentry/components/alert';
Expand Down Expand Up @@ -45,24 +45,25 @@ const pageErrorContext = createContext<{
export function PageAlertProvider({children}: {children: React.ReactNode}) {
const [pageAlert, setPageAlert] = useState<PageAlertOptions | undefined>();

const setPageInfo: PageAlertSetter = (message, options) => {
const setPageInfo: PageAlertSetter = useCallback((message, options) => {
setPageAlert({message, type: 'info', ...options});
};
const setPageMuted: PageAlertSetter = (message, options) => {
}, []);

const setPageMuted: PageAlertSetter = useCallback((message, options) => {
setPageAlert({message, type: 'muted', ...options});
};
}, []);

const setPageSuccess: PageAlertSetter = (message, options) => {
const setPageSuccess: PageAlertSetter = useCallback((message, options) => {
setPageAlert({message, type: 'success', ...options});
};
}, []);

const setPageWarning: PageAlertSetter = (message, options) => {
const setPageWarning: PageAlertSetter = useCallback((message, options) => {
setPageAlert({message, type: 'warning', ...options});
};
}, []);

const setPageError: PageAlertSetter = (message, options) => {
const setPageError: PageAlertSetter = useCallback((message, options) => {
setPageAlert({message, type: 'error', ...options});
};
}, []);

return (
<pageErrorContext.Provider
Expand Down