From 29d793939a0abdaf5a039a3cf5b18b46857aca1f Mon Sep 17 00:00:00 2001 From: anthony sottile Date: Wed, 24 Jul 2024 17:15:22 -0400 Subject: [PATCH] ref: unify signature of create_issue --- src/sentry/plugins/bases/issue.py | 2 +- src/sentry/plugins/bases/issue2.py | 2 +- src/sentry/plugins/examples/issue_tracking.py | 2 +- src/sentry_plugins/asana/plugin.py | 2 +- src/sentry_plugins/bitbucket/plugin.py | 2 +- src/sentry_plugins/github/plugin.py | 2 +- src/sentry_plugins/gitlab/plugin.py | 2 +- src/sentry_plugins/jira/plugin.py | 2 +- src/sentry_plugins/phabricator/plugin.py | 2 +- src/sentry_plugins/pivotal/plugin.py | 2 +- src/sentry_plugins/redmine/plugin.py | 2 +- src/sentry_plugins/trello/plugin.py | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/sentry/plugins/bases/issue.py b/src/sentry/plugins/bases/issue.py index 7a40d7f837fc54..5fca514f323db1 100644 --- a/src/sentry/plugins/bases/issue.py +++ b/src/sentry/plugins/bases/issue.py @@ -143,7 +143,7 @@ def get_issue_label(self, group, issue_id, **kwargs): """ return "#%s" % issue_id - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): """ Creates the issue on the remote service and returns an issue ID. """ diff --git a/src/sentry/plugins/bases/issue2.py b/src/sentry/plugins/bases/issue2.py index c2d41901aebaf7..6b514b60d50e14 100644 --- a/src/sentry/plugins/bases/issue2.py +++ b/src/sentry/plugins/bases/issue2.py @@ -173,7 +173,7 @@ def get_issue_label(self, group, issue, **kwargs): return "#{}".format(issue["id"]) return f"#{issue}" - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): """ Creates the issue on the remote service and returns an issue ID. diff --git a/src/sentry/plugins/examples/issue_tracking.py b/src/sentry/plugins/examples/issue_tracking.py index 51fdf58f60f866..c951dedb5997dc 100644 --- a/src/sentry/plugins/examples/issue_tracking.py +++ b/src/sentry/plugins/examples/issue_tracking.py @@ -28,7 +28,7 @@ def get_new_issue_fields(self, request: Request, group, event, **kwargs): *fields, ] - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): return "1" def get_issue_label(self, group, issue_id, **kwargs): diff --git a/src/sentry_plugins/asana/plugin.py b/src/sentry_plugins/asana/plugin.py index 847760a0a3d284..2b423ad685e592 100644 --- a/src/sentry_plugins/asana/plugin.py +++ b/src/sentry_plugins/asana/plugin.py @@ -143,7 +143,7 @@ def error_message_from_json(self, data): return " ".join(e["message"] for e in errors) return "unknown error" - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): client = self.get_client(request.user) try: diff --git a/src/sentry_plugins/bitbucket/plugin.py b/src/sentry_plugins/bitbucket/plugin.py index d1db1be56b92ba..9dfe4d5f236442 100644 --- a/src/sentry_plugins/bitbucket/plugin.py +++ b/src/sentry_plugins/bitbucket/plugin.py @@ -130,7 +130,7 @@ def message_from_error(self, exc): return ERR_404 return super().message_from_error(exc) - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): client = self.get_client(request.user) try: diff --git a/src/sentry_plugins/github/plugin.py b/src/sentry_plugins/github/plugin.py index 9c948fe1922751..e90aee3ec8c5cc 100644 --- a/src/sentry_plugins/github/plugin.py +++ b/src/sentry_plugins/github/plugin.py @@ -164,7 +164,7 @@ def get_allowed_assignees(self, request: Request, group): return (("", "Unassigned"),) + users - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): # TODO: support multiple identities via a selection input in the form? with self.get_client(request.user) as client: try: diff --git a/src/sentry_plugins/gitlab/plugin.py b/src/sentry_plugins/gitlab/plugin.py index 6c07bfd924e48c..8ba31078ff7367 100644 --- a/src/sentry_plugins/gitlab/plugin.py +++ b/src/sentry_plugins/gitlab/plugin.py @@ -109,7 +109,7 @@ def get_client(self, project): return GitLabClient(url, token) - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): repo = self.get_option("gitlab_repo", group.project) client = self.get_client(group.project) diff --git a/src/sentry_plugins/jira/plugin.py b/src/sentry_plugins/jira/plugin.py index d13c05f847a515..bf435d1ba6e238 100644 --- a/src/sentry_plugins/jira/plugin.py +++ b/src/sentry_plugins/jira/plugin.py @@ -414,7 +414,7 @@ def error_message_from_json(self, data): message += " ".join(f"{k}: {v}" for k, v in data.get("errors").items()) return message - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): cleaned_data = {} # protect against mis-configured plugin submitting a form without an diff --git a/src/sentry_plugins/phabricator/plugin.py b/src/sentry_plugins/phabricator/plugin.py index 199fdadadc1483..5979cd837dbdb7 100644 --- a/src/sentry_plugins/phabricator/plugin.py +++ b/src/sentry_plugins/phabricator/plugin.py @@ -227,7 +227,7 @@ def view_autocomplete(self, request: Request, group, **kwargs): return Response({field: results}) - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): api = self.get_api(group.project) try: data = api.maniphest.createtask( diff --git a/src/sentry_plugins/pivotal/plugin.py b/src/sentry_plugins/pivotal/plugin.py index cdeff68749d4ae..3ee22b36f68291 100644 --- a/src/sentry_plugins/pivotal/plugin.py +++ b/src/sentry_plugins/pivotal/plugin.py @@ -146,7 +146,7 @@ def make_api_request(self, project, _url, json_data=None): } return safe_urlopen(_url, json=json_data, headers=req_headers, allow_redirects=True) - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): json_data = { "story_type": "bug", "name": force_str(form_data["title"], encoding="utf-8", errors="replace"), diff --git a/src/sentry_plugins/redmine/plugin.py b/src/sentry_plugins/redmine/plugin.py index 5081f852cb0ff5..61133bc37f663f 100644 --- a/src/sentry_plugins/redmine/plugin.py +++ b/src/sentry_plugins/redmine/plugin.py @@ -82,7 +82,7 @@ def get_client(self, project): host=self.get_option("host", project), key=self.get_option("key", project) ) - def create_issue(self, group, form_data, **kwargs): + def create_issue(self, request, group, form_data): """ Create a Redmine issue """ diff --git a/src/sentry_plugins/trello/plugin.py b/src/sentry_plugins/trello/plugin.py index b8dd0f1d911e53..c0c521891a4dba 100644 --- a/src/sentry_plugins/trello/plugin.py +++ b/src/sentry_plugins/trello/plugin.py @@ -204,7 +204,7 @@ def error_message_from_json(self, data): return " ".join(e["message"] for e in errors) return "unknown error" - def create_issue(self, request: Request, group, form_data, **kwargs): + def create_issue(self, request: Request, group, form_data): client = self.get_client(group.project) try: