Skip to content

test(alerts): Write test for deleting metric alert rule #76254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2024
Merged

test(alerts): Write test for deleting metric alert rule #76254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13b607
test(alerts): Write test for deleting metric alert rule
schew2381 Aug 15, 2024
7064d76
remove fluff
schew2381 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 52 additions & 17 deletions static/app/views/alerts/list/rules/alertRulesList.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,35 +179,70 @@ describe('AlertRulesList', () => {
expect(screen.getByText('Duplicate')).toBeInTheDocument();
});

it('deletes a rule', async () => {
const {router, organization} = initializeOrg({
organization: defaultOrg,
it('deletes an issue rule', async () => {
Copy link
Contributor Author

@schew2381 schew2381 Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaned up this test as well

const deletedRuleName = 'Issue Rule';
const issueRule = ProjectAlertRuleFixture({
name: deletedRuleName,
projects: ['project-slug'],
});
const deletedRuleName = 'First Issue Alert';

MockApiClient.addMockResponse({
url: '/organizations/org-slug/combined-rules/',
headers: {Link: pageLinks},
body: [
{
...ProjectAlertRuleFixture({
id: '123',
name: deletedRuleName,
projects: ['earth'],
createdBy: {name: 'Samwise', id: 1, email: ''},
}),
type: CombinedAlertType.ISSUE,
},
],
body: [{...issueRule, type: CombinedAlertType.ISSUE}],
});

const {router, project, organization} = initializeOrg({organization: defaultOrg});
render(<AlertRulesList />, {router, organization});
renderGlobalModal();

const deleteMock = MockApiClient.addMockResponse({
url: `/projects/${organization.slug}/earth/rules/123/`,
url: `/projects/${organization.slug}/${project.slug}/rules/${issueRule.id}/`,
method: 'DELETE',
body: {},
});

const actions = (await screen.findAllByRole('button', {name: 'Actions'}))[0];

// Add a new response to the mock with no rules
const emptyListMock = MockApiClient.addMockResponse({
url: '/organizations/org-slug/combined-rules/',
headers: {Link: pageLinks},
body: [],
});

expect(screen.queryByText(deletedRuleName)).toBeInTheDocument();
await userEvent.click(actions);
await userEvent.click(screen.getByRole('menuitemradio', {name: 'Delete'}));
await userEvent.click(screen.getByRole('button', {name: 'Delete Rule'}));

expect(deleteMock).toHaveBeenCalledTimes(1);
expect(emptyListMock).toHaveBeenCalledTimes(1);
expect(screen.queryByText(deletedRuleName)).not.toBeInTheDocument();
});

it('deletes a metric rule', async () => {
const deletedRuleName = 'Metric Rule';
const metricRule = MetricRuleFixture({
name: deletedRuleName,
});

MockApiClient.addMockResponse({
url: '/organizations/org-slug/combined-rules/',
headers: {Link: pageLinks},
body: [{...metricRule, type: CombinedAlertType.METRIC}],
});

const {router, organization} = initializeOrg({organization: defaultOrg});
render(<AlertRulesList />, {router, organization});
renderGlobalModal();

const deleteMock = MockApiClient.addMockResponse({
url: `/organizations/${organization.slug}/alert-rules/${metricRule.id}/`,
method: 'DELETE',
body: {},
});

const actions = (await screen.findAllByRole('button', {name: 'Actions'}))[0];

// Add a new response to the mock with no rules
Expand All @@ -219,7 +254,7 @@ describe('AlertRulesList', () => {

expect(screen.queryByText(deletedRuleName)).toBeInTheDocument();
await userEvent.click(actions);
await userEvent.click(screen.getByText('Delete'));
await userEvent.click(screen.getByRole('menuitemradio', {name: 'Delete'}));
await userEvent.click(screen.getByRole('button', {name: 'Delete Rule'}));

expect(deleteMock).toHaveBeenCalledTimes(1);
Expand Down