Skip to content

ref: remove unnecssary metaclass #91906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

ref: remove unnecssary metaclass #91906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/sentry/hybridcloud/rpc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import threading
from collections.abc import Callable, Iterable, Mapping
from enum import Enum
from typing import Any, Generic, Protocol, Self, TypeVar, cast
from typing import Any, Generic, Self, TypeVar, cast

import pydantic
from django.db import router, transaction
Expand Down Expand Up @@ -99,10 +99,6 @@ def serialize_by_field_name(
return cls(**fields)


class RpcModelProtocolMeta(type(RpcModel), type(Protocol)): # type: ignore[misc]
"""A unifying metaclass for RpcModel classes that also implement a Protocol."""


ServiceInterface = TypeVar("ServiceInterface")


Expand Down
4 changes: 2 additions & 2 deletions src/sentry/sentry_apps/services/app/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from pydantic.fields import Field

from sentry.constants import SentryAppInstallationStatus
from sentry.hybridcloud.rpc import RpcModel, RpcModelProtocolMeta
from sentry.hybridcloud.rpc import RpcModel
from sentry.sentry_apps.utils.errors import SentryAppErrorType


Expand Down Expand Up @@ -124,7 +124,7 @@ def actionType(self) -> str: ...
def is_enabled(self) -> bool: ...


class RpcSentryAppEventData(RpcModel, metaclass=RpcModelProtocolMeta):
class RpcSentryAppEventData(RpcModel):
id: str = ""
label: str = ""
action_type: str = ""
Expand Down
Loading