Revert changes to zero_init_texture_after_discard

[teoxoy]

See #3626 (comment).

[teoxoy]

CI is running into a bunch of:

Validation Error: [ UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout ] Object 0: handle = 0x7fc6592d0110, type = VK_OBJECT_TYPE_COMMAND_BUFFER; Object 1: handle = 0xd10d270000000018, name = RenderTarget, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0x4dae5635 | vkQueueSubmit(): pSubmits[0].pCommandBuffers[1] command buffer VkCommandBuffer 0x7fc6592d0110[] expects VkImage 0xd10d270000000018[RenderTarget] (subresource: aspectMask 0x2 array layer 0, mip level 0) to be in layout VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL--instead, current layout is VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL.

@gents83 are those the same errors you also encountered?

[gents83]

CI is running into a bunch of:

Validation Error: [ UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout ] Object 0: handle = 0x7fc6592d0110, type = VK_OBJECT_TYPE_COMMAND_BUFFER; Object 1: handle = 0xd10d270000000018, name = RenderTarget, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0x4dae5635 | vkQueueSubmit(): pSubmits[0].pCommandBuffers[1] command buffer VkCommandBuffer 0x7fc6592d0110[] expects VkImage 0xd10d270000000018[RenderTarget] (subresource: aspectMask 0x2 array layer 0, mip level 0) to be in layout VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL--instead, current layout is VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL.

@gents83 are those the same errors you also encountered?

Sorry it tooks a while to find the correct changelist that I was trying to fix:
https://github.com/gfx-rs/wgpu/actions/runs/6517160199/job/17701370210?pr=3626

Apparently it was very similar issue but on DX12 - it seems always a wrong state of the resource:

[2023-10-14T10:51:15Z ERROR wgpu_hal::auxil::dxgi::exception] ID3D12CommandQueue::ExecuteCommandLists: Using ResourceBarrier on Command List (0x0000017CF97B0100:'Unnamed ID3D12GraphicsCommandList Object'): Before state (0xC0: D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE|D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE) of resource (0x0000017CE19F1DB0:'RenderTarget') (subresource: 0) specified by transition barrier does not match with the state (0x10: D3D12_RESOURCE_STATE_DEPTH_WRITE) specified in the previous call to ResourceBarrier [ RESOURCE_MANIPULATION ERROR #527: RESOURCE_BARRIER_BEFORE_AFTER_MISMATCH]
[2023-10-14T10:51:15Z ERROR wgpu_hal::auxil::dxgi::exception] ID3D12CommandQueue::ExecuteCommandLists: Using ResourceBarrier on Command List (0x0000017CF97B0100:'Unnamed ID3D12GraphicsCommandList Object'): Before state (0xC0: D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE|D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE) of resource (0x0000017CE19F1DB0:'RenderTarget') (subresource: 1) specified by transition barrier does not match with the state (0x10: D3D12_RESOURCE_STATE_DEPTH_WRITE) specified in the previous call to ResourceBarrier [ RESOURCE_MANIPULATION ERROR #527: RESOURCE_BARRIER_BEFORE_AFTER_MISMATCH]