Skip to content

Conversation

@cwfitzgerald
Copy link
Member

Connections

#5701 exposed that if you name snapshots using two different frontends the same thing, they will conflict in wgsl-out.

Description

This prefixes every snapshot with a prefix of their input.

Testing

It is.

Squash or Rebase?

Squash

@cwfitzgerald cwfitzgerald force-pushed the cw/prefix-snapshot-outputs branch from 611a0a1 to 57fda7e Compare April 2, 2025 22:19
@cwfitzgerald cwfitzgerald marked this pull request as ready for review April 2, 2025 22:19
@cwfitzgerald cwfitzgerald force-pushed the cw/prefix-snapshot-outputs branch from 57fda7e to b39c8b7 Compare April 3, 2025 14:57
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) April 3, 2025 14:58
@cwfitzgerald cwfitzgerald merged commit f7bcc62 into gfx-rs:trunk Apr 3, 2025
37 checks passed
@cwfitzgerald cwfitzgerald deleted the cw/prefix-snapshot-outputs branch April 3, 2025 15:30
Vecvec pushed a commit to Vecvec/wgpu that referenced this pull request Apr 11, 2025
jimblandy pushed a commit to jimblandy/wgpu that referenced this pull request Apr 18, 2025
sharmajai pushed a commit to sharmajai/wgpu that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants