Skip to content

Commit af1fdc6

Browse files
committed
please.sh: start using mingw-w64-git-extra instead of git-extra
In a recent commit, we started publishing the mingw-w64-git-extra package in addition to git-extra. We intend to completely remove the old git-extra package over time, but let's start using the new mingw-w64-git-extra prefix now. More background on this change can be found in the attached commit. Ref: 3f26b1b Signed-off-by: Dennis Ameling <[email protected]>
1 parent d081a9a commit af1fdc6

File tree

1 file changed

+23
-9
lines changed

1 file changed

+23
-9
lines changed

please.sh

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,18 @@ sync () { # [--force]
210210
test "$only" = "$sdk" ||
211211
continue
212212

213+
case "$sdk" in
214+
"$sdk32")
215+
PACMAN_ARCH=i686
216+
;;
217+
"$sdk64")
218+
PACMAN_ARCH=x86_64
219+
;;
220+
*)
221+
die "Invalid SDK $sdk"
222+
;;
223+
esac
224+
213225
mkdir -p "$sdk/var/log" ||
214226
die "Could not ensure %s/var/log/ exists\n" "$sdk"
215227

@@ -282,11 +294,11 @@ sync () { # [--force]
282294
gem install asciidoctor' ||
283295
die "Could not re-install asciidoctor in %s\n" "$sdk"
284296

285-
# git-extra rewrites some files owned by other packages,
297+
# mingw-w64-git-extra rewrites some files owned by other packages,
286298
# therefore it has to be (re-)installed now
287299
"$sdk/git-cmd.exe" --command=usr\\bin\\bash.exe -l -c \
288-
'pacman -S '$force' --noconfirm git-extra' ||
289-
die "Cannot update git-extra in %s\n" "$sdk"
300+
'pacman -S '$force' --noconfirm mingw-w64-'$PACMAN_ARCH'-git-extra' || HELLODENNIS
301+
die "Cannot update mingw-w64-git-extra in %s\n" "$sdk"
290302

291303
pacnew="$(sed -ne '/starting core system upgrade/{
292304
:1;
@@ -302,15 +314,15 @@ sync () { # [--force]
302314
die "Could not get list of .pacnew files\n"
303315
if test -n "$pacnew"
304316
then
305-
# Make sure we have the git-extra package locally, as
317+
# Make sure we have the mingw-w64-git-extra package locally, as
306318
# one of the .pacnew files could be pacman.conf, and
307319
# replacing it removes the link to Git for Windows'
308320
# Pacman repository
309321
"$sdk/git-cmd.exe" --command=usr\\bin\\bash.exe -l -c \
310-
'pkg=/var/cache/pacman/pkg/$(pacman -Q git-extra |
322+
'pkg=/var/cache/pacman/pkg/$(pacman -Q mingw-w64-'$PACMAN_ARCH'-git-extra |
311323
tr \ -)*.pkg.tar.xz
312324
test -f $pkg || {
313-
pacman -Sw --noconfirm git-extra &&
325+
pacman -Sw --noconfirm mingw-w64-'$PACMAN_ARCH'-git-extra &&
314326
test -f $pkg || {
315327
echo "Could not cache $pkg" >&2
316328
exit 1
@@ -344,9 +356,11 @@ set_package () {
344356
extra_packages=
345357
extra_makepkg_opts=
346358
case "$package" in
347-
git-extra)
359+
git-extra|mingw-w64-git-extra)
360+
package=mingw-w64-git-extra
348361
type=MINGW
349-
pkgpath=/usr/src/build-extra/$package
362+
# This will need to be replaced with mingw-w64-git-extra once the folder has been renamed
363+
pkgpath=/usr/src/build-extra/git-extra
350364
;;
351365
git-for-windows-keyring)
352366
type=MSYS
@@ -3752,7 +3766,7 @@ make_installers_from_mingw_w64_git () { # [--pkg=<package>[,<package>...]] [--ve
37523766
37533767
test -z "$install_package" || {
37543768
eval pacman -U --noconfirm --overwrite=\\\* $install_package &&
3755-
(. /var/lib/pacman/local/git-extra-*/install && post_install)
3769+
(. /var/lib/pacman/local/*-git-extra-*/install && post_install)
37563770
} ||
37573771
die "Could not install packages: %s\n" "$install_package"
37583772

0 commit comments

Comments
 (0)