From d38329be3abaf6e9914b8214814bbcb7070cf737 Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Tue, 4 Nov 2025 12:49:50 +0100 Subject: [PATCH] github-release: prepare for immutable releases There is a new initiative to increase confidence in GitHub Releases: https://github.blog/changelog/2025-10-28-immutable-releases-are-now-generally-available/ The official guidance is to create a draft release, then attach all assets, then publish: https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/immutable-releases#best-practices-for-publishing-immutable-releases We _almost_ do that already. The only exception is the additional update to create a discussion for each new release. This was separated out earlier in response to a missing permission of the GitHub App used to perform the job, but is likely incompatible with immutable releases. So let's revert b59f512 (github-release: create the Discussion separately, 2024-09-18). Signed-off-by: Johannes Schindelin --- .github/actions/github-release/action.yml | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/.github/actions/github-release/action.yml b/.github/actions/github-release/action.yml index 35f6c5a3..62d7186e 100644 --- a/.github/actions/github-release/action.yml +++ b/.github/actions/github-release/action.yml @@ -159,25 +159,9 @@ runs: draft: false, prerelease: isPrerelease, make_latest : !isPrerelease, + discussion_category_name: 'Announcements', } ) - - try { - await state.refreshToken() - console.log('Opening announcement (in Discussions)') - await updateRelease( - console, - state.accessToken, - '${{ inputs.owner }}', - '${{ inputs.repo }}', - release.id, { - discussion_category_name: 'Announcements', - } - ) - } catch(e) { - console.log(`::warning::could not create Discussion`) - console.log(e) - } core.setOutput('token', state.accessToken) - name: Add a comment about the announcement email to the Pull Request if: inputs.pull-request-number != ''