strbuf_readlink: support link targets that exceed PATH_MAX

kblees · dscho · commit 37dbe3449031 · 2018-11-15T22:12:31.000+01:00
strbuf_readlink() refuses to read link targets that exceed PATH_MAX (even
if a sufficient size was specified by the caller).

As some platforms support longer paths, remove this restriction (similar
to strbuf_getcwd()).

Signed-off-by: Karsten Blees &lt;blees@dcon.de&gt;
diff --git a/strbuf.c b/strbuf.c
@@ -459,16 +459,14 @@ ssize_t strbuf_write(struct strbuf *sb, FILE *f)
 }
 
 
-#define STRBUF_MAXLINK (2*PATH_MAX)
-
 int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint)
 {
 	size_t oldalloc = sb->alloc;
 
 	if (hint < 32)
 		hint = 32;
 
-	while (hint < STRBUF_MAXLINK) {
+	for (;;) {
 		ssize_t len;
 
 		strbuf_grow(sb, hint + 1);

Original file line number	Diff line number	Diff line change
`@@ -459,16 +459,14 @@ ssize_t strbuf_write(struct strbuf sb, FILE f)`
`459`	`459`	`}`
`460`	`460`
`461`	`461`
`462`		`-#define STRBUF_MAXLINK (2*PATH_MAX)`
`463`		`-`
`464`	`462`	`int strbuf_readlink(struct strbuf sb, const char path, size_t hint)`
`465`	`463`	`{`
`466`	`464`	`size_t oldalloc = sb->alloc;`
`467`	`465`
`468`	`466`	`if (hint < 32)`
`469`	`467`	`hint = 32;`
`470`	`468`
`471`		`- while (hint < STRBUF_MAXLINK) {`
	`469`	`+ for (;;) {`
`472`	`470`	`ssize_t len;`
`473`	`471`
`474`	`472`	`strbuf_grow(sb, hint + 1);`