Skip to content

Commit 3f2d07a

Browse files
kbleesdscho
authored andcommitted
Win32: implement basic symlink() functionality (file symlinks only)
Implement symlink() that always creates file symlinks. Fails with ENOSYS if symlinks are disabled or unsupported. Note: CreateSymbolicLinkW() was introduced with symlink support in Windows Vista. For compatibility with Windows XP, we need to load it dynamically and fail gracefully if it isnt's available. Signed-off-by: Karsten Blees <[email protected]>
1 parent d810715 commit 3f2d07a

File tree

2 files changed

+29
-2
lines changed

2 files changed

+29
-2
lines changed

compat/mingw.c

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2264,6 +2264,34 @@ int link(const char *oldpath, const char *newpath)
22642264
return 0;
22652265
}
22662266

2267+
int symlink(const char *target, const char *link)
2268+
{
2269+
wchar_t wtarget[MAX_LONG_PATH], wlink[MAX_LONG_PATH];
2270+
int len;
2271+
2272+
/* fail if symlinks are disabled or API is not supported (WinXP) */
2273+
if (!has_symlinks) {
2274+
errno = ENOSYS;
2275+
return -1;
2276+
}
2277+
2278+
if ((len = xutftowcs_long_path(wtarget, target)) < 0
2279+
|| xutftowcs_long_path(wlink, link) < 0)
2280+
return -1;
2281+
2282+
/* convert target dir separators to backslashes */
2283+
while (len--)
2284+
if (wtarget[len] == '/')
2285+
wtarget[len] = '\\';
2286+
2287+
/* create file symlink */
2288+
if (!CreateSymbolicLinkW(wlink, wtarget, 0)) {
2289+
errno = err_win_to_posix(GetLastError());
2290+
return -1;
2291+
}
2292+
return 0;
2293+
}
2294+
22672295
#ifndef _WINNT_H
22682296
/*
22692297
* The REPARSE_DATA_BUFFER structure is defined in the Windows DDK (in

compat/mingw.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ struct utsname {
123123
* trivial stubs
124124
*/
125125

126-
static inline int symlink(const char *oldpath, const char *newpath)
127-
{ errno = ENOSYS; return -1; }
128126
static inline int fchmod(int fildes, mode_t mode)
129127
{ errno = ENOSYS; return -1; }
130128
#ifndef __MINGW64_VERSION_MAJOR
@@ -216,6 +214,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out);
216214
int sigaction(int sig, struct sigaction *in, struct sigaction *out);
217215
int link(const char *oldpath, const char *newpath);
218216
int uname(struct utsname *buf);
217+
int symlink(const char *target, const char *link);
219218
int readlink(const char *path, char *buf, size_t bufsiz);
220219

221220
/*

0 commit comments

Comments
 (0)